[PR #1155] [FIX] Initialize fatal_ftn before first use

claunia commented

2026-01-29 17:19:22 +00:00

Owner

Original Pull Request: https://github.com/CCExtractor/ccextractor/pull/1155

State: closed
Merged: Yes

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.
I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

In init_libraries, if the first call to malloc to initialise the lib_ccx_ctx struct fails, fatal_ftn is called. However, the first definition of fatal_ftn occurs if the call succeeds, meaning that fatal_ftn is undefined at the first possible call.

By initialising the logging functions before any other code is run, meaning that fatal_ftn should always be defined when called.

**Original Pull Request:** https://github.com/CCExtractor/ccextractor/pull/1155 **State:** closed **Merged:** Yes --- Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [x] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [x] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- In `init_libraries`, if the first call to `malloc` to initialise the `lib_ccx_ctx` struct fails, `fatal_ftn` is called. However, the first definition of `fatal_ftn` occurs if the call succeeds, meaning that `fatal_ftn` is undefined at the first possible call. By initialising the logging functions before any other code is run, meaning that `fatal_ftn` should always be defined when called.

claunia added the pull-request label 2026-01-29 17:19:22 +00:00

claunia closed this issue

2026-01-29 17:19:22 +00:00

claunia referenced this issue

2026-01-29 17:23:44 +00:00

[PR #1944] ci(windows): Optimize Windows build workflow for faster CI #2750

[PR #1155] [FIX] Initialize fatal_ftn before first use #1944