[PR #1165] [FIX] Change inet_ntop to inet_ntoa for Windows XP compatibility

claunia commented

2026-01-29 17:19:24 +00:00

Owner

Original Pull Request: https://github.com/CCExtractor/ccextractor/pull/1165

State: closed
Merged: Yes

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.
I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

#1116
The change allows the command-line version of ccextractor to be built for Windows XP and run on it as well. The following occurs without the changes because inet_ntop() is not supported on Windows XP.

CCX was built on a Windows 10 machine using Visual Studio 2017 targeted for Windows XP and then run on a Windows XP VM. Visual Studio 2019 doesn't support targeting for Windows XP.

**Original Pull Request:** https://github.com/CCExtractor/ccextractor/pull/1165 **State:** closed **Merged:** Yes --- **In raising this pull request, I confirm the following (please check boxes):** - [X] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [X] I have checked that another pull request for this purpose does not exist. - [X] I have considered, and confirmed that this submission will be valuable to others. - [X] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [X] I give this submission freely, and claim no ownership to its content. - [X] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [X] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- #1116 The change allows the command-line version of ccextractor to be built for Windows XP and run on it as well. The following occurs without the changes because inet_ntop() is not supported on Windows XP. ![image](https://user-images.githubusercontent.com/21135985/71591804-b2043700-2afb-11ea-98ae-6b13287b20ef.png) CCX was built on a Windows 10 machine using Visual Studio 2017 targeted for Windows XP and then run on a Windows XP VM. Visual Studio 2019 doesn't support targeting for Windows XP.

claunia added the pull-request label 2026-01-29 17:19:24 +00:00

claunia closed this issue

2026-01-29 17:19:25 +00:00

claunia referenced this issue

2026-01-29 17:23:45 +00:00

[PR #1951] [CLOSED] Fix/isdbcc stack overflow #2753

[PR #1165] [FIX] Change inet_ntop to inet_ntoa for Windows XP compatibility #1950