[PR #1167] [MERGED] [Fix] Make -delay all output formats #1951

New Issue

claunia · 2026-01-29T17:19:26Z

claunia commented

2026-01-29 17:19:26 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1167
Author: @NilsIrl
Created: 1/1/2020
Status: ✅ Merged
Merged: 1/10/2020
Merged by: @cfsmp3

Base: master ← Head: #1103

📝 Commits (4)

ecdffba Fix indentation
4fb75f4 Calculate subs_delay in encode_sub rather than in the individual encoders
4e94a1c Use precalculated times when sub->type == CC_TEXT
e872e14 Use calculate delay in encode_sub when sub->type == CC_608

📊 Changes

13 files changed (+70 additions, -181 deletions)

View changed files

📝 src/lib_ccx/ccx_decoders_common.c (+1 -1)
📝 src/lib_ccx/ccx_encoders_common.c (+16 -18)
📝 src/lib_ccx/ccx_encoders_curl.c (+0 -1)
📝 src/lib_ccx/ccx_encoders_g608.c (+2 -10)
📝 src/lib_ccx/ccx_encoders_python.c (+2 -10)
📝 src/lib_ccx/ccx_encoders_sami.c (+4 -18)
📝 src/lib_ccx/ccx_encoders_smptett.c (+4 -16)
📝 src/lib_ccx/ccx_encoders_spupng.c (+1 -18)
📝 src/lib_ccx/ccx_encoders_srt.c (+8 -26)
📝 src/lib_ccx/ccx_encoders_ssa.c (+4 -16)
📝 src/lib_ccx/ccx_encoders_transcript.c (+18 -25)
📝 src/lib_ccx/ccx_encoders_webvtt.c (+4 -16)
📝 src/lib_ccx/ccx_encoders_xds.c (+6 -6)

📄 Description

Fix #1103

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.
I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

I have used CCExtractor just a couple of times.

Move up the pipeline, when the calculation of delay is done.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1167 **Author:** [@NilsIrl](https://github.com/NilsIrl) **Created:** 1/1/2020 **Status:** ✅ Merged **Merged:** 1/10/2020 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `#1103` --- ### 📝 Commits (4) - [`ecdffba`](https://github.com/CCExtractor/ccextractor/commit/ecdffbac070f41a1274a28160092a7c8e1133362) Fix indentation - [`4fb75f4`](https://github.com/CCExtractor/ccextractor/commit/4fb75f479d8899c6afec24b3e3275e2ed92a3dcc) Calculate subs_delay in encode_sub rather than in the individual encoders - [`4e94a1c`](https://github.com/CCExtractor/ccextractor/commit/4e94a1c1bfd3057f06d613a9014739ff38ecf5e1) Use precalculated times when sub->type == CC_TEXT - [`e872e14`](https://github.com/CCExtractor/ccextractor/commit/e872e1485d47cb0e8040ca77aea857ad6e3ebac3) Use calculate delay in encode_sub when sub->type == CC_608 ### 📊 Changes **13 files changed** (+70 additions, -181 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/ccx_decoders_common.c` (+1 -1) 📝 `src/lib_ccx/ccx_encoders_common.c` (+16 -18) 📝 `src/lib_ccx/ccx_encoders_curl.c` (+0 -1) 📝 `src/lib_ccx/ccx_encoders_g608.c` (+2 -10) 📝 `src/lib_ccx/ccx_encoders_python.c` (+2 -10) 📝 `src/lib_ccx/ccx_encoders_sami.c` (+4 -18) 📝 `src/lib_ccx/ccx_encoders_smptett.c` (+4 -16) 📝 `src/lib_ccx/ccx_encoders_spupng.c` (+1 -18) 📝 `src/lib_ccx/ccx_encoders_srt.c` (+8 -26) 📝 `src/lib_ccx/ccx_encoders_ssa.c` (+4 -16) 📝 `src/lib_ccx/ccx_encoders_transcript.c` (+18 -25) 📝 `src/lib_ccx/ccx_encoders_webvtt.c` (+4 -16) 📝 `src/lib_ccx/ccx_encoders_xds.c` (+6 -6) </details> ### 📄 Description Fix #1103 - [X] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [X] I have checked that another pull request for this purpose does not exist. - [X] I have considered, and confirmed that this submission will be valuable to others. - [X] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [X] I give this submission freely, and claim no ownership to its content. - [ ] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [X] I have used CCExtractor just a couple of times. Move up the pipeline, when the calculation of delay is done. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 17:19:26 +00:00

claunia referenced this issue

2026-01-29 17:23:45 +00:00

[PR #1951] [CLOSED] Fix/isdbcc stack overflow #2753

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#1951