[PR #1176] [MERGED] [FIX] Added the option to disable timestamps for WebVTT #1964

Closed
opened 2026-01-29 17:19:29 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1176
Author: @dhrumilp15
Created: 1/12/2020
Status: Merged
Merged: 1/13/2020
Merged by: @cfsmp3

Base: masterHead: disable_timestamps


📝 Commits (5)

  • ca2ab74 Added the option to disable timestamps for WebVTT
  • 3889a82 Mentioned in changelog
  • 13290c1 Added the option to params.c
  • 81d7f79 Encoder checks its context nwo
  • 6ca2946 Encoder checks its context

📊 Changes

7 files changed (+29 additions, -4 deletions)

View changed files

📝 docs/CHANGES.TXT (+1 -0)
📝 src/lib_ccx/ccx_common_option.c (+2 -0)
📝 src/lib_ccx/ccx_common_option.h (+3 -1)
📝 src/lib_ccx/ccx_encoders_common.c (+1 -0)
📝 src/lib_ccx/ccx_encoders_common.h (+2 -0)
📝 src/lib_ccx/ccx_encoders_webvtt.c (+13 -3)
📝 src/lib_ccx/params.c (+7 -0)

📄 Description

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

In response to issue #1127, this fix adds an option to remove the X-TIMESTAMP-MAP header for WebVTT.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1176 **Author:** [@dhrumilp15](https://github.com/dhrumilp15) **Created:** 1/12/2020 **Status:** ✅ Merged **Merged:** 1/13/2020 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `disable_timestamps` --- ### 📝 Commits (5) - [`ca2ab74`](https://github.com/CCExtractor/ccextractor/commit/ca2ab744a1788059bf542bb594d4ab687379cc3f) Added the option to disable timestamps for WebVTT - [`3889a82`](https://github.com/CCExtractor/ccextractor/commit/3889a82f68fb1a9baaa23a78c2de1475c6f4928e) Mentioned in changelog - [`13290c1`](https://github.com/CCExtractor/ccextractor/commit/13290c1aef9e9a995d0892bc763937b310b00d49) Added the option to params.c - [`81d7f79`](https://github.com/CCExtractor/ccextractor/commit/81d7f79efccd2ed95c1e19cb721e551fd87a3ce9) Encoder checks its context nwo - [`6ca2946`](https://github.com/CCExtractor/ccextractor/commit/6ca29460448069db527b563669c3cafc7b004df7) Encoder checks its context ### 📊 Changes **7 files changed** (+29 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `docs/CHANGES.TXT` (+1 -0) 📝 `src/lib_ccx/ccx_common_option.c` (+2 -0) 📝 `src/lib_ccx/ccx_common_option.h` (+3 -1) 📝 `src/lib_ccx/ccx_encoders_common.c` (+1 -0) 📝 `src/lib_ccx/ccx_encoders_common.h` (+2 -0) 📝 `src/lib_ccx/ccx_encoders_webvtt.c` (+13 -3) 📝 `src/lib_ccx/params.c` (+7 -0) </details> ### 📄 Description Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [x] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [x] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- In response to issue #1127, this fix adds an option to remove the X-TIMESTAMP-MAP header for WebVTT. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:19:29 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#1964