[PR #1177] [MERGED] [FIX] wrong format string #1965

Closed
opened 2026-01-29 17:19:29 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1177
Author: @NilsIrl
Created: 1/13/2020
Status: Merged
Merged: 1/13/2020
Merged by: @cfsmp3

Base: masterHead: fix_1176


📝 Commits (1)

📊 Changes

1 file changed (+1 additions, -6 deletions)

View changed files

📝 src/lib_ccx/ccx_encoders_webvtt.c (+1 -6)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I have used CCExtractor just a couple of times.

This fixes erronous code added by #1176.

It also fixes a "vulnerability" added by it which would allow someone with access to the input and output file to leak memory content. (such as with the sample platform).

It is almost unexploitable though due to ASLR.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1177 **Author:** [@NilsIrl](https://github.com/NilsIrl) **Created:** 1/13/2020 **Status:** ✅ Merged **Merged:** 1/13/2020 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `fix_1176` --- ### 📝 Commits (1) - [`eef36a5`](https://github.com/CCExtractor/ccextractor/commit/eef36a591f125bc1a328b72970a4d558b6393357) Fix wrong format string ### 📊 Changes **1 file changed** (+1 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/ccx_encoders_webvtt.c` (+1 -6) </details> ### 📄 Description **In raising this pull request, I confirm the following (please check boxes):** - [X] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [X] I have checked that another pull request for this purpose does not exist. - [X] I have considered, and confirmed that this submission will be valuable to others. - [X] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [X] I give this submission freely, and claim no ownership to its content. **My familiarity with the project is as follows (check one):** - [X] I have used CCExtractor just a couple of times. --- This fixes erronous code added by #1176. It also fixes a "vulnerability" added by it which would allow someone with access to the input and output file to leak memory content. (such as with the sample platform). It is almost unexploitable though due to ASLR. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:19:29 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#1965