[PR #1179] [MERGED] [IMPROVEMENT] Add noreturn attribute to fatal #1967

New Issue

claunia · 2026-01-29T17:19:30Z

claunia commented

2026-01-29 17:19:30 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1179
Author: @NilsIrl
Created: 1/13/2020
Status: ✅ Merged
Merged: 1/23/2020
Merged by: @cfsmp3

Base: master ← Head: warning_1

📝 Commits (2)

0c288a4 Set no return
dc42615 Add MSVC

📊 Changes

1 file changed (+5 additions, -0 deletions)

View changed files

📝 src/lib_ccx/lib_ccx.h (+5 -0)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

I have used CCExtractor just a couple of times.

Removes the following warnings:

52a52,55
> /home/nils/Documents/codein2019/ccextractor/src/lib_ccx/asf_functions.c: In function ‘asf_readval’:
> /home/nils/Documents/codein2019/ccextractor/src/lib_ccx/asf_functions.c:39:9: warning: ‘rval’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>   return rval;
>          ^~~~
1652a1656,1663
> /home/nils/Documents/codein2019/ccextractor/src/lib_ccx/general_loop.c: In function ‘process_data’:
> /home/nils/Documents/codein2019/ccextractor/src/lib_ccx/general_loop.c:741:5: warning: ‘got’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>   if (got > data_node->len)
>      ^
> /home/nils/Documents/codein2019/ccextractor/src/lib_ccx/general_loop.c: In function ‘general_loop’:
> /home/nils/Documents/codein2019/ccextractor/src/lib_ccx/general_loop.c:896:9: warning: ‘get_more_data’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>    ret = get_more_data(ctx, &datalist);
>          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1179 **Author:** [@NilsIrl](https://github.com/NilsIrl) **Created:** 1/13/2020 **Status:** ✅ Merged **Merged:** 1/23/2020 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `warning_1` --- ### 📝 Commits (2) - [`0c288a4`](https://github.com/CCExtractor/ccextractor/commit/0c288a412676c65d86b1d6730dae62659d90ebbc) Set no return - [`dc42615`](https://github.com/CCExtractor/ccextractor/commit/dc426159cdb65140a3f20336df3afdf8f5b3daab) Add MSVC ### 📊 Changes **1 file changed** (+5 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/lib_ccx.h` (+5 -0) </details> ### 📄 Description **In raising this pull request, I confirm the following (please check boxes):** - [X] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [X] I have checked that another pull request for this purpose does not exist. - [X] I have considered, and confirmed that this submission will be valuable to others. - [X] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [X] I give this submission freely, and claim no ownership to its content. **My familiarity with the project is as follows (check one):** - [X] I have used CCExtractor just a couple of times. --- Removes the following warnings: ```patch 52a52,55 > /home/nils/Documents/codein2019/ccextractor/src/lib_ccx/asf_functions.c: In function ‘asf_readval’: > /home/nils/Documents/codein2019/ccextractor/src/lib_ccx/asf_functions.c:39:9: warning: ‘rval’ may be used uninitialized in this function [-Wmaybe-uninitialized] > return rval; > ^~~~ 1652a1656,1663 > /home/nils/Documents/codein2019/ccextractor/src/lib_ccx/general_loop.c: In function ‘process_data’: > /home/nils/Documents/codein2019/ccextractor/src/lib_ccx/general_loop.c:741:5: warning: ‘got’ may be used uninitialized in this function [-Wmaybe-uninitialized] > if (got > data_node->len) > ^ > /home/nils/Documents/codein2019/ccextractor/src/lib_ccx/general_loop.c: In function ‘general_loop’: > /home/nils/Documents/codein2019/ccextractor/src/lib_ccx/general_loop.c:896:9: warning: ‘get_more_data’ may be used uninitialized in this function [-Wmaybe-uninitialized] > ret = get_more_data(ctx, &datalist); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 17:19:30 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#1967