[PR #1179] [IMPROVEMENT] Add noreturn attribute to fatal #1971

New Issue

claunia · 2026-01-29T17:19:30Z

claunia commented

2026-01-29 17:19:30 +00:00

Original Pull Request: https://github.com/CCExtractor/ccextractor/pull/1179

State: closed
Merged: Yes

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

I have used CCExtractor just a couple of times.

Removes the following warnings:

52a52,55
> /home/nils/Documents/codein2019/ccextractor/src/lib_ccx/asf_functions.c: In function ‘asf_readval’:
> /home/nils/Documents/codein2019/ccextractor/src/lib_ccx/asf_functions.c:39:9: warning: ‘rval’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>   return rval;
>          ^~~~
1652a1656,1663
> /home/nils/Documents/codein2019/ccextractor/src/lib_ccx/general_loop.c: In function ‘process_data’:
> /home/nils/Documents/codein2019/ccextractor/src/lib_ccx/general_loop.c:741:5: warning: ‘got’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>   if (got > data_node->len)
>      ^
> /home/nils/Documents/codein2019/ccextractor/src/lib_ccx/general_loop.c: In function ‘general_loop’:
> /home/nils/Documents/codein2019/ccextractor/src/lib_ccx/general_loop.c:896:9: warning: ‘get_more_data’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>    ret = get_more_data(ctx, &datalist);
>          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

**Original Pull Request:** https://github.com/CCExtractor/ccextractor/pull/1179 **State:** closed **Merged:** Yes --- **In raising this pull request, I confirm the following (please check boxes):** - [X] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [X] I have checked that another pull request for this purpose does not exist. - [X] I have considered, and confirmed that this submission will be valuable to others. - [X] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [X] I give this submission freely, and claim no ownership to its content. **My familiarity with the project is as follows (check one):** - [X] I have used CCExtractor just a couple of times. --- Removes the following warnings: ```patch 52a52,55 > /home/nils/Documents/codein2019/ccextractor/src/lib_ccx/asf_functions.c: In function ‘asf_readval’: > /home/nils/Documents/codein2019/ccextractor/src/lib_ccx/asf_functions.c:39:9: warning: ‘rval’ may be used uninitialized in this function [-Wmaybe-uninitialized] > return rval; > ^~~~ 1652a1656,1663 > /home/nils/Documents/codein2019/ccextractor/src/lib_ccx/general_loop.c: In function ‘process_data’: > /home/nils/Documents/codein2019/ccextractor/src/lib_ccx/general_loop.c:741:5: warning: ‘got’ may be used uninitialized in this function [-Wmaybe-uninitialized] > if (got > data_node->len) > ^ > /home/nils/Documents/codein2019/ccextractor/src/lib_ccx/general_loop.c: In function ‘general_loop’: > /home/nils/Documents/codein2019/ccextractor/src/lib_ccx/general_loop.c:896:9: warning: ‘get_more_data’ may be used uninitialized in this function [-Wmaybe-uninitialized] > ret = get_more_data(ctx, &datalist); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ```

claunia added the pull-request label 2026-01-29 17:19:30 +00:00

claunia closed this issue

2026-01-29 17:19:31 +00:00

claunia referenced this issue

2026-01-29 17:23:50 +00:00

[PR #1971] [MERGED] [FEATURE] Add --scc-accurate-timing option for bandwidth-aware SCC output (fixes #1221) #2771

claunia referenced this issue

2026-01-29 17:23:50 +00:00

[PR #1971] [FEATURE] Add --scc-accurate-timing option for bandwidth-aware SCC output (fixes #1221) #2775

Sign in to join this conversation.