[PR #1183] [MERGED] [FIX] Allow -dvblang that doesn't follow ISO 639-2 #1973

Open
opened 2026-01-29 17:19:32 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1183
Author: @NilsIrl
Created: 1/15/2020
Status: Merged
Merged: 1/16/2020
Merged by: @cfsmp3

Base: masterHead: dvblang


📝 Commits (2)

  • e747e76 Allow -dvblang that doesn't follow ISO 639-2
  • 9567f98 Allows 'und' to be specified to -dvblang

📊 Changes

3 files changed (+12 additions, -18 deletions)

View changed files

📝 src/lib_ccx/dvb_subtitle_decoder.c (+10 -10)
📝 src/lib_ccx/ocr.c (+0 -6)
📝 src/lib_ccx/ts_tables.c (+2 -2)

📄 Description

Fix #1161

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I have used CCExtractor just a couple of times.

Check against the dvb data instead of passing through languages.

Stop checking if OCR lang == dvblang (as it prevents from setting a non ISO dvblang).


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1183 **Author:** [@NilsIrl](https://github.com/NilsIrl) **Created:** 1/15/2020 **Status:** ✅ Merged **Merged:** 1/16/2020 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `dvblang` --- ### 📝 Commits (2) - [`e747e76`](https://github.com/CCExtractor/ccextractor/commit/e747e76030f183deb29d10fb04af13028be1a90c) Allow `-dvblang` that doesn't follow ISO 639-2 - [`9567f98`](https://github.com/CCExtractor/ccextractor/commit/9567f983ab72b4f6010caf0df2d62380eb711562) Allows 'und' to be specified to `-dvblang` ### 📊 Changes **3 files changed** (+12 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/dvb_subtitle_decoder.c` (+10 -10) 📝 `src/lib_ccx/ocr.c` (+0 -6) 📝 `src/lib_ccx/ts_tables.c` (+2 -2) </details> ### 📄 Description Fix #1161 **In raising this pull request, I confirm the following (please check boxes):** - [X] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [X] I have checked that another pull request for this purpose does not exist. - [X] I have considered, and confirmed that this submission will be valuable to others. - [X] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [X] I give this submission freely, and claim no ownership to its content. **My familiarity with the project is as follows (check one):** - [X] I have used CCExtractor just a couple of times. --- Check against the dvb data instead of passing through `languages`. Stop checking if OCR lang == dvblang (as it prevents from setting a non ISO dvblang). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:19:32 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#1973