[PR #1184] [MERGED] [FIX] Add FT_Done_Face to destroy face objects after they're used

claunia commented

2026-01-29 17:19:33 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1184
Author: @jshin313
Created: 1/15/2020
Status: ✅ Merged
Merged: 1/15/2020
Merged by: @cfsmp3

Base: master ← Head: done_face

📝 Commits (2)

0311b22 Add FT_Done_Face to destroy face objects after they're used
72ee251 Update CHANGES.TXT

📊 Changes

2 files changed (+3 additions, -0 deletions)

View changed files

📝 docs/CHANGES.TXT (+1 -0)
📝 src/lib_ccx/ccx_encoders_spupng.c (+2 -0)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.
I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

For large files (>~1 GB), the out=spupng option would stop prematurely because the FT_Face objects used by the spupng_export_string2png() function were never destroyed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1184 **Author:** [@jshin313](https://github.com/jshin313) **Created:** 1/15/2020 **Status:** ✅ Merged **Merged:** 1/15/2020 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `done_face` --- ### 📝 Commits (2) - [`0311b22`](https://github.com/CCExtractor/ccextractor/commit/0311b22cb105eeb330260ef2d5d1b7c3dca380c6) Add FT_Done_Face to destroy face objects after they're used - [`72ee251`](https://github.com/CCExtractor/ccextractor/commit/72ee251feb7043094e3da696aa5ce0fc780d1b84) Update CHANGES.TXT ### 📊 Changes **2 files changed** (+3 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `docs/CHANGES.TXT` (+1 -0) 📝 `src/lib_ccx/ccx_encoders_spupng.c` (+2 -0) </details> ### 📄 Description **In raising this pull request, I confirm the following (please check boxes):** - [X] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [X] I have checked that another pull request for this purpose does not exist. - [X] I have considered, and confirmed that this submission will be valuable to others. - [X] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [X] I give this submission freely, and claim no ownership to its content. - [X] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [X] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- For large files (>~1 GB), the out=spupng option would stop prematurely because the FT_Face objects used by the spupng_export_string2png() function were never destroyed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>