starred/ccextractor
1
0
Fork 0
mirror of https://github.com/CCExtractor/ccextractor.git synced 2026-04-18 03:52:46 +00:00
Code Issues 1.5k Packages Projects Releases 21 Wiki Activity

[PR #1204] [MERGED] [FIX] GCC warning fixes #1999

New Issue
Closed
opened 2026-01-29 17:19:40 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 17:19:40 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1204
Author: @kdrag0n
Created: 1/21/2020
Status: ✅ Merged
Merged: 1/24/2020
Merged by: @cfsmp3

Base: master ← Head: gcc-warning-fixes

📝 Commits (10+)

  • b7d4615 cea708: Fix missing new line in log message
  • c98fc88 subtype: Remove unused CC_708 type
  • 4af09ba build: Disable pointer-sign warning
  • 5aaf943 splitbysentence: Fix warnings
  • a415544 spupng: Fix warnings
  • a0868ce webvtt: Fix missing return warning
  • cb01e51 gxf: Fix MIN macro redefinition warning
  • 8e1130b dvd: Fix unused variable warnings
  • d6b591f es_functions: Fix unused variable warning
  • 083c126 dvb: Fix unused variable warning when OCR is disabled

📊 Changes

27 files changed (+113 additions, -145 deletions)

View changed files

📝 api/build_api (+1 -1)
📝 linux/Makefile.am (+1 -1)
📝 linux/build (+1 -1)
📝 linux/build-static.sh (+1 -1)
📝 linux/build_hardsubx (+1 -1)
📝 linux/builddebug (+1 -1)
📝 mac/Makefile.am (+1 -1)
📝 mac/build.command (+1 -1)
📝 src/lib_ccx/CMakeLists.txt (+1 -1)
📝 src/lib_ccx/ccx_common_structs.h (+0 -1)
📝 src/lib_ccx/ccx_decoders_708.c (+1 -1)
📝 src/lib_ccx/ccx_encoders_splitbysentence.c (+73 -74)
📝 src/lib_ccx/ccx_encoders_spupng.c (+5 -9)
📝 src/lib_ccx/ccx_encoders_webvtt.c (+3 -3)
📝 src/lib_ccx/ccx_gxf.c (+0 -1)
📝 src/lib_ccx/dvb_subtitle_decoder.c (+1 -2)
📝 src/lib_ccx/dvd_subtitle_decoder.c (+3 -5)
📝 src/lib_ccx/es_functions.c (+0 -8)
📝 src/lib_ccx/general_loop.c (+1 -4)
📝 src/lib_ccx/matroska.c (+1 -1)

...and 7 more files

📄 Description

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog. (combined in #1205)

My familiarity with the project is as follows (check one):

  • I have used CCExtractor just a couple of times.

This fixes all warnings reported by GCC 9.2.0 in the core CCExtractor code, excluding vendored libraries.

Several actual issues were caught in the process:

These changes make all of the core code build with zero warnings on the latest stable version of GCC at the time of writing, both with and without OCR enabled.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1204 **Author:** [@kdrag0n](https://github.com/kdrag0n) **Created:** 1/21/2020 **Status:** ✅ Merged **Merged:** 1/24/2020 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `gcc-warning-fixes` --- ### 📝 Commits (10+) - [`b7d4615`](https://github.com/CCExtractor/ccextractor/commit/b7d46156a680bc3b40e56f38b4d7b22d837f01fa) cea708: Fix missing new line in log message - [`c98fc88`](https://github.com/CCExtractor/ccextractor/commit/c98fc886ebb2e733d7136a7b85b8396be09dc36b) subtype: Remove unused CC_708 type - [`4af09ba`](https://github.com/CCExtractor/ccextractor/commit/4af09ba49257b1ce846875eb1ae021e38bb50149) build: Disable pointer-sign warning - [`5aaf943`](https://github.com/CCExtractor/ccextractor/commit/5aaf9437aa2c3d29c2b38a0e0b0b660d4a9a3edc) splitbysentence: Fix warnings - [`a415544`](https://github.com/CCExtractor/ccextractor/commit/a4155446abb98d4cf525f8d2c73b07b03dced0ec) spupng: Fix warnings - [`a0868ce`](https://github.com/CCExtractor/ccextractor/commit/a0868ced6a208dc75eaf30e6068384c0abc74745) webvtt: Fix missing return warning - [`cb01e51`](https://github.com/CCExtractor/ccextractor/commit/cb01e5136c5654cc02b9e4e929e423f829ce577f) gxf: Fix MIN macro redefinition warning - [`8e1130b`](https://github.com/CCExtractor/ccextractor/commit/8e1130bcb97187c25d45436ae4db3f221f0f4614) dvd: Fix unused variable warnings - [`d6b591f`](https://github.com/CCExtractor/ccextractor/commit/d6b591f2c7bb173b8c8a6be7eb953fc96f14fa19) es_functions: Fix unused variable warning - [`083c126`](https://github.com/CCExtractor/ccextractor/commit/083c126f7e4114362bedf4420b6d8cf6990735da) dvb: Fix unused variable warning when OCR is disabled ### 📊 Changes **27 files changed** (+113 additions, -145 deletions) <details> <summary>View changed files</summary> 📝 `api/build_api` (+1 -1) 📝 `linux/Makefile.am` (+1 -1) 📝 `linux/build` (+1 -1) 📝 `linux/build-static.sh` (+1 -1) 📝 `linux/build_hardsubx` (+1 -1) 📝 `linux/builddebug` (+1 -1) 📝 `mac/Makefile.am` (+1 -1) 📝 `mac/build.command` (+1 -1) 📝 `src/lib_ccx/CMakeLists.txt` (+1 -1) 📝 `src/lib_ccx/ccx_common_structs.h` (+0 -1) 📝 `src/lib_ccx/ccx_decoders_708.c` (+1 -1) 📝 `src/lib_ccx/ccx_encoders_splitbysentence.c` (+73 -74) 📝 `src/lib_ccx/ccx_encoders_spupng.c` (+5 -9) 📝 `src/lib_ccx/ccx_encoders_webvtt.c` (+3 -3) 📝 `src/lib_ccx/ccx_gxf.c` (+0 -1) 📝 `src/lib_ccx/dvb_subtitle_decoder.c` (+1 -2) 📝 `src/lib_ccx/dvd_subtitle_decoder.c` (+3 -5) 📝 `src/lib_ccx/es_functions.c` (+0 -8) 📝 `src/lib_ccx/general_loop.c` (+1 -4) 📝 `src/lib_ccx/matroska.c` (+1 -1) _...and 7 more files_ </details> ### 📄 Description **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [x] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** (combined in #1205) **My familiarity with the project is as follows (check one):** - [x] I have used CCExtractor just a couple of times. --- This fixes all warnings reported by GCC 9.2.0 in the core CCExtractor code, excluding vendored libraries. Several actual issues were caught in the process: - [Missing new line in a CEA-708 log message](https://github.com/CCExtractor/ccextractor/commit/a920bab0d664395ad975653f9828365750a35efb) (not a warning, but caught in the process nonetheless) - [Empty encoding in parameter dump when ASCII is used](https://github.com/CCExtractor/ccextractor/commit/670d5a045584505f750381269756662f0bfe393a) - [Incorrect stream mode comparisons](https://github.com/CCExtractor/ccextractor/commit/af9027a29d4a00a619e18801450b394d6dbe1202) These changes make all of the core code build with zero warnings on the latest stable version of GCC at the time of writing, both with and without OCR enabled. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:19:40 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
CEA-708
difficulty: easy
difficulty: hard
difficulty: medium
DTMB
DVB
enhancement
enhancement
Flutter GUI
GCI19
good-first-task
GSoC 2021
GSOC-2023
GSOC-2023
GSOC-2023
GSoC-related
Hacktoberfest
HardsubX
help wanted
invalid
JokerTV
Mac / OSX
more-info-needed
needs-commercial-sponsor
needs-commercial-sponsor
needs-commercial-sponsor
needs-confirmation-of-being-broken
OCR
pull-request
Mirrored from GitHub Pull Request
 Python
regression
Rust
teletext
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#1999
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?