[PR #1205] [MERGED] [FIX] Clang warning fixes #2002

New Issue

claunia · 2026-01-29T17:19:42Z

claunia commented

2026-01-29 17:19:42 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1205
Author: @kdrag0n
Created: 1/21/2020
Status: ✅ Merged
Merged: 1/30/2020
Merged by: @cfsmp3

Base: master ← Head: clang-warning-fixes

📝 Commits (10+)

3711eed file_buffer: Fix unitialized variable usage warning
3c08d37 common_timing: Fix uninitialized variable usage warning
c25e7ac encoders: Fix handling of multibyte characters in UTF-8 converter
20d07c0 gxf: Fix tautological comparison warnings
f9ebfb4 gxf: Fix uninitialized variable usage warnings
da8cd33 ts_functions: Fix incorrect enumeration type in get_buffer_type
0fa6adf utility: Fix tautological comparison warnings
63875ed ocr: Fix floating point -> integer abs() warning
eaa98ce encoders: Fix incorrect string types when EIA-608 is in use
546f4f0 ocr: Fix implicit struct declaration warning

📊 Changes

10 files changed (+42 additions, -51 deletions)

View changed files

📝 src/lib_ccx/ccx_common_timing.c (+2 -1)
📝 src/lib_ccx/ccx_encoders_common.c (+14 -14)
📝 src/lib_ccx/ccx_encoders_helpers.c (+10 -10)
📝 src/lib_ccx/ccx_encoders_helpers.h (+1 -1)
📝 src/lib_ccx/ccx_gxf.c (+8 -14)
📝 src/lib_ccx/file_buffer.h (+1 -1)
📝 src/lib_ccx/ocr.c (+2 -1)
📝 src/lib_ccx/ocr.h (+1 -0)
📝 src/lib_ccx/ts_functions.c (+1 -1)
📝 src/lib_ccx/utility.c (+2 -8)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.
I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

I have used CCExtractor just a couple of times.

This fixes all warnings reported by Clang 9.0.1 in the core CCExtractor code, excluding vendored libraries.

These changes combined with #1204 make all of the core code build with zero warnings on the latest stable versions of both GCC and Clang at the time of writing, both with and without OCR enabled.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1205 **Author:** [@kdrag0n](https://github.com/kdrag0n) **Created:** 1/21/2020 **Status:** ✅ Merged **Merged:** 1/30/2020 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `clang-warning-fixes` --- ### 📝 Commits (10+) - [`3711eed`](https://github.com/CCExtractor/ccextractor/commit/3711eeddc42ca5685ccbb426c5a56756a70b8d43) file_buffer: Fix unitialized variable usage warning - [`3c08d37`](https://github.com/CCExtractor/ccextractor/commit/3c08d375ae9835132c6ff284720e0e98b0f2ced7) common_timing: Fix uninitialized variable usage warning - [`c25e7ac`](https://github.com/CCExtractor/ccextractor/commit/c25e7acadb9494a4c30bae35a7343cca22a9a208) encoders: Fix handling of multibyte characters in UTF-8 converter - [`20d07c0`](https://github.com/CCExtractor/ccextractor/commit/20d07c0e08603756facfcba7d3b3c0cd0441b99f) gxf: Fix tautological comparison warnings - [`f9ebfb4`](https://github.com/CCExtractor/ccextractor/commit/f9ebfb4b5b90fca4ae0841ef8f0f8de3367e1aac) gxf: Fix uninitialized variable usage warnings - [`da8cd33`](https://github.com/CCExtractor/ccextractor/commit/da8cd33ef23494e91e27f07241eb8d8902e4678b) ts_functions: Fix incorrect enumeration type in get_buffer_type - [`0fa6adf`](https://github.com/CCExtractor/ccextractor/commit/0fa6adfe8bc922e102aed5ad1f8236633637f708) utility: Fix tautological comparison warnings - [`63875ed`](https://github.com/CCExtractor/ccextractor/commit/63875ed53951f68b907ef7d76a8b6c690bfb686c) ocr: Fix floating point -> integer abs() warning - [`eaa98ce`](https://github.com/CCExtractor/ccextractor/commit/eaa98ced0c0df80ba1bd035a8b0e056456dd7911) encoders: Fix incorrect string types when EIA-608 is in use - [`546f4f0`](https://github.com/CCExtractor/ccextractor/commit/546f4f0a268758be084ed7f827b4b7513e8cb1e6) ocr: Fix implicit struct declaration warning ### 📊 Changes **10 files changed** (+42 additions, -51 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/ccx_common_timing.c` (+2 -1) 📝 `src/lib_ccx/ccx_encoders_common.c` (+14 -14) 📝 `src/lib_ccx/ccx_encoders_helpers.c` (+10 -10) 📝 `src/lib_ccx/ccx_encoders_helpers.h` (+1 -1) 📝 `src/lib_ccx/ccx_gxf.c` (+8 -14) 📝 `src/lib_ccx/file_buffer.h` (+1 -1) 📝 `src/lib_ccx/ocr.c` (+2 -1) 📝 `src/lib_ccx/ocr.h` (+1 -0) 📝 `src/lib_ccx/ts_functions.c` (+1 -1) 📝 `src/lib_ccx/utility.c` (+2 -8) </details> ### 📄 Description **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [x] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [x] I have used CCExtractor just a couple of times. --- This fixes all warnings reported by Clang 9.0.1 in the core CCExtractor code, excluding vendored libraries. These changes combined with #1204 make all of the core code build with zero warnings on the latest stable versions of both GCC and Clang at the time of writing, both with and without OCR enabled. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 17:19:42 +00:00

claunia referenced this issue

2026-01-29 17:23:59 +00:00

[PR #2002] Fix uninitialized options #2804

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#2002