[PR #1208] [MERGED] [FIX] Write all SCC characters in pairs (fixes playback in MPV) #2003

Closed
opened 2026-01-29 17:19:42 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1208
Author: @kdrag0n
Created: 1/22/2020
Status: Merged
Merged: 1/22/2020
Merged by: @cfsmp3

Base: masterHead: scc-pair-fix


📝 Commits (1)

  • b5e5d0d scc: Write all characters in pairs

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/lib_ccx/ccx_encoders_scc.c (+1 -1)

📄 Description

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I have used CCExtractor just a couple of times.

This is how every example appears to be structured, and MPV doesn't display anything without this change.

Before: e5 f2 e5 20
After: e5f2 e520


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1208 **Author:** [@kdrag0n](https://github.com/kdrag0n) **Created:** 1/22/2020 **Status:** ✅ Merged **Merged:** 1/22/2020 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `scc-pair-fix` --- ### 📝 Commits (1) - [`b5e5d0d`](https://github.com/CCExtractor/ccextractor/commit/b5e5d0df3c6e74f15c31def5d36714de05473ddd) scc: Write all characters in pairs ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/ccx_encoders_scc.c` (+1 -1) </details> ### 📄 Description Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. **My familiarity with the project is as follows (check one):** - [x] I have used CCExtractor just a couple of times. --- This is how every example appears to be structured, and MPV doesn't display anything without this change. Before: `e5 f2 e5 20` After: `e5f2 e520` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:19:42 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2003