[PR #1210] [MERGED] [FIX] SCC character pair writing #2007

Open
opened 2026-01-29 17:19:45 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1210
Author: @kdrag0n
Created: 1/23/2020
Status: Merged
Merged: 1/23/2020
Merged by: @cfsmp3

Base: masterHead: scc-pair-fix2


📝 Commits (2)

  • 4c7ed6e scc: Fix character pair writing
  • 326ad2c scc: Apply pair writing to control codes

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 src/lib_ccx/ccx_encoders_scc.c (+2 -2)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I have used CCExtractor just a couple of times.

The space was being inserted in the wrong position, so the first character of each caption was being cut off. The last character was also cut off in captions with even lengths.

Thanks to @NilsIrl for reporting this issue.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1210 **Author:** [@kdrag0n](https://github.com/kdrag0n) **Created:** 1/23/2020 **Status:** ✅ Merged **Merged:** 1/23/2020 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `scc-pair-fix2` --- ### 📝 Commits (2) - [`4c7ed6e`](https://github.com/CCExtractor/ccextractor/commit/4c7ed6efeff7c0bb107a88e82f096c90ee879f9c) scc: Fix character pair writing - [`326ad2c`](https://github.com/CCExtractor/ccextractor/commit/326ad2cca787f5112fb72ae7f5464241fee518f2) scc: Apply pair writing to control codes ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/ccx_encoders_scc.c` (+2 -2) </details> ### 📄 Description **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. **My familiarity with the project is as follows (check one):** - [x] I have used CCExtractor just a couple of times. --- The space was being inserted in the wrong position, so the first character of each caption was being cut off. The last character was also cut off in captions with even lengths. Thanks to @NilsIrl for reporting this issue. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:19:45 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2007