[PR #1211] [MERGED] [FIX] Fix SCC timing and lingering captions #2009

New Issue

claunia · 2026-01-29T17:19:45Z

claunia commented

2026-01-29 17:19:45 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1211
Author: @kdrag0n
Created: 1/23/2020
Status: ✅ Merged
Merged: 1/23/2020
Merged by: @cfsmp3

Base: master ← Head: scc-timing-fix

📝 Commits (3)

5b8b696 scc: Fix timing and lingering captions
d507218 scc: Calculate frame number using a more precise frame rate
180fcd4 scc: Fix timecode format specifiers

📊 Changes

1 file changed (+23 additions, -9 deletions)

View changed files

📝 src/lib_ccx/ccx_encoders_scc.c (+23 -9)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

I have used CCExtractor just a couple of times.

This includes 2 changes:

Write EDM codes at end times to clear them from the screen as intended by the captioners
Show captions at the correct times:
- EOC+ENM shows the caption. It doesn't clear it — that's EDM's job.
- The caption is not shown immediately after loading. EOC (End Of Caption) is required for it to actually show.

Old behavior:

Start time: Load caption
End time: Show loaded caption

New behavior:

Start time: Load and show caption
End time: Clear displayed caption

These changes fix the issue where captions were always one line off — that is, caption 1 would show when caption 2 was supposed to show.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1211 **Author:** [@kdrag0n](https://github.com/kdrag0n) **Created:** 1/23/2020 **Status:** ✅ Merged **Merged:** 1/23/2020 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `scc-timing-fix` --- ### 📝 Commits (3) - [`5b8b696`](https://github.com/CCExtractor/ccextractor/commit/5b8b6962ea88395940eef33394d6deba4d7c16ca) scc: Fix timing and lingering captions - [`d507218`](https://github.com/CCExtractor/ccextractor/commit/d50721862654db7b05354c46bfaf8883c1732ec6) scc: Calculate frame number using a more precise frame rate - [`180fcd4`](https://github.com/CCExtractor/ccextractor/commit/180fcd4e5fd4effd21e3156e1a68966c91640d53) scc: Fix timecode format specifiers ### 📊 Changes **1 file changed** (+23 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/ccx_encoders_scc.c` (+23 -9) </details> ### 📄 Description **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. **My familiarity with the project is as follows (check one):** - [x] I have used CCExtractor just a couple of times. --- This includes 2 changes: - Write EDM codes at end times to clear them from the screen as intended by the captioners - Show captions at the correct times: - EOC+ENM *shows* the caption. It doesn't clear it — that's EDM's job. - The caption is *not* shown immediately after loading. EOC (End Of Caption) is required for it to actually show. Old behavior: - Start time: Load caption - End time: Show loaded caption New behavior: - Start time: Load and show caption - End time: Clear displayed caption These changes fix the issue where captions were always one line off — that is, caption 1 would show when caption 2 was supposed to show. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 17:19:45 +00:00

claunia closed this issue

2026-01-29 17:19:45 +00:00

claunia referenced this issue

2026-01-29 17:24:03 +00:00

[PR #2009] fix(ts): allow manual streamtype override for private streams #2815

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#2009