[PR #1219] [IMPROVEMENT] Move dependencies to a third party directory #2019

Closed
opened 2026-01-29 17:19:48 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/CCExtractor/ccextractor/pull/1219

State: closed
Merged: Yes


In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I am an active contributor to CCExtractor.

Move thirdparty dependencies to /src/thirdparty and remove redundant code in linux/builddebug and linux/build_hardsubx.

Add .clang-format and github action to check if the code is formatted.

Why?

  • Allows to easily differentiate between dependencies and ccextractor code:
    • Makes it a lot less confusing to new contributors as to why there are files everywhere.
    • Tools can leverage this to only act on some files (e.g. clang-format)
**Original Pull Request:** https://github.com/CCExtractor/ccextractor/pull/1219 **State:** closed **Merged:** Yes --- **In raising this pull request, I confirm the following (please check boxes):** - [X] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [X] I have checked that another pull request for this purpose does not exist. - [X] I have considered, and confirmed that this submission will be valuable to others. - [X] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [X] I give this submission freely, and claim no ownership to its content. **My familiarity with the project is as follows (check one):** - [X] I am an active contributor to CCExtractor. --- Move thirdparty dependencies to /src/thirdparty and remove redundant code in linux/builddebug and linux/build_hardsubx. Add `.clang-format` and github action to check if the code is formatted. Why? * Allows to easily differentiate between dependencies and ccextractor code: - Makes it a **lot** less confusing to new contributors as to why there are files everywhere. - Tools can leverage this to only act on some files (e.g. `clang-format`)
claunia added the pull-request label 2026-01-29 17:19:48 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2019