[PR #1226] [MERGED] [FIX] Fix multiple definitions with new -fno-common default in GCC 10 #2021

Open
opened 2026-01-29 17:19:50 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1226
Author: @logic
Created: 2/1/2020
Status: Merged
Merged: 2/2/2020
Merged by: @cfsmp3

Base: masterHead: gcc10-fno-common


📝 Commits (2)

  • dfd2502 Fix multiple definitions with new -fno-common default in GCC 10
  • 0b47c2f Add GCC 10 fix to changelog

📊 Changes

4 files changed (+8 additions, -4 deletions)

View changed files

📝 docs/CHANGES.TXT (+1 -0)
📝 src/ccextractor.c (+3 -0)
📝 src/ccextractor.h (+2 -2)
📝 src/lib_ccx/ccx_decoders_708.h (+2 -2)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

GCC 10 defaults to -fno-common, which results in multiple definitions of a few variables; this is mentioned in the GCC 10 release notes and the GCC 10 porting guide. Closes #1225.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1226 **Author:** [@logic](https://github.com/logic) **Created:** 2/1/2020 **Status:** ✅ Merged **Merged:** 2/2/2020 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `gcc10-fno-common` --- ### 📝 Commits (2) - [`dfd2502`](https://github.com/CCExtractor/ccextractor/commit/dfd25022e2a775a8b5eb03e4ad28bab6fe6a0658) Fix multiple definitions with new -fno-common default in GCC 10 - [`0b47c2f`](https://github.com/CCExtractor/ccextractor/commit/0b47c2fec6ba776f8469eba9422cc9bc39f7dbfc) Add GCC 10 fix to changelog ### 📊 Changes **4 files changed** (+8 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `docs/CHANGES.TXT` (+1 -0) 📝 `src/ccextractor.c` (+3 -0) 📝 `src/ccextractor.h` (+2 -2) 📝 `src/lib_ccx/ccx_decoders_708.h` (+2 -2) </details> ### 📄 Description **In raising this pull request, I confirm the following (please check boxes):** - [X] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [X] I have checked that another pull request for this purpose does not exist. - [X] I have considered, and confirmed that this submission will be valuable to others. - [X] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [X] I give this submission freely, and claim no ownership to its content. - [X] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [X] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- GCC 10 defaults to `-fno-common`, which results in multiple definitions of a few variables; this is mentioned in the [GCC 10 release notes](https://gcc.gnu.org/gcc-10/changes.html) and the [GCC 10 porting guide](https://gcc.gnu.org/gcc-10/porting_to.html). Closes #1225. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:19:50 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2021