[PR #1229] [MERGED] [FIX] Fix tags displaying incorrectly #2025

New Issue

claunia · 2026-01-29T17:19:50Z

claunia commented

2026-01-29 17:19:50 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1229
Author: @NilsIrl
Created: 2/12/2020
Status: ✅ Merged
Merged: 2/12/2020
Merged by: @cfsmp3

Base: master ← Head: nils_tags_incorrect

📝 Commits (1)

e3245dc [FIX] Fix tags displaying incorrectly

📊 Changes

1 file changed (+30 additions, -11 deletions)

View changed files

📝 src/lib_ccx/ccx_decoders_608.c (+30 -11)

📄 Description

This was caused by 19241744d7, moving from
unsigned char to enums for colors and fonts. The problem with this is
that each colour isn't one byte next to each other so memcpy and memset
didn't work anymore.

The problem:

6812,6813c6812,6813
< EDITION OF AMERICA'S NEXT TOP
< <i> MODEL</i> ON WEDNESDAYS.<i>          </i>
---
> EDITION OF<i> AMERICA'S NEXT TOP</i>
> <i> MODEL</i> ON WEDNESDAYS.
6817c6817
< EDITION OF AMERICA'S NEXT TOP
---
> EDITION OF<i> AMERICA'S NEXT TOP</i>
6819c6819
< >><i> THE VAMPIRE DIARIES         </i>
---
> >><i> THE VAMPIRE DIARIES</i>
6824,6825c6824,6825
< >><i> THE VA</i>MPIRE DIARIES
< AND<i> THE SECRET CIRCLE          </i>
---
> >><i> THE VAMPIRE DIARIES</i>
> AND<i> THE SECRET CIRCLE</i>
6829,6831c6829,6831
< >><i> THE VA</i>MPIRE DIARIES
< AND<i> THE S</i>ECRET CIRCLE
< ON THURSDAYS.<i>                  </i>
---
> >><i> THE VAMPIRE DIARIES</i>
> AND<i> THE SECRET CIRCLE</i>
> ON THURSDAYS.
6835c6835
< AND<i> THE S</i>ECRET CIRCLE
---
> AND<i> THE SECRET CIRCLE</i>

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1229 **Author:** [@NilsIrl](https://github.com/NilsIrl) **Created:** 2/12/2020 **Status:** ✅ Merged **Merged:** 2/12/2020 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `nils_tags_incorrect` --- ### 📝 Commits (1) - [`e3245dc`](https://github.com/CCExtractor/ccextractor/commit/e3245dc3ab1501cff0ae777e3d3a8edff3795c26) [FIX] Fix tags displaying incorrectly ### 📊 Changes **1 file changed** (+30 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/ccx_decoders_608.c` (+30 -11) </details> ### 📄 Description This was caused by 19241744d71adeda0f29c553b966236e88312c94, moving from `unsigned char` to `enums` for colors and fonts. The problem with this is that each colour isn't one byte next to each other so memcpy and memset didn't work anymore. The problem: ```patch 6812,6813c6812,6813 < EDITION OF AMERICA'S NEXT TOP < MODEL ON WEDNESDAYS. --- > EDITION OF AMERICA'S NEXT TOP > MODEL ON WEDNESDAYS. 6817c6817 < EDITION OF AMERICA'S NEXT TOP --- > EDITION OF AMERICA'S NEXT TOP 6819c6819 < >> THE VAMPIRE DIARIES --- > >> THE VAMPIRE DIARIES 6824,6825c6824,6825 < >> THE VAMPIRE DIARIES < AND THE SECRET CIRCLE --- > >> THE VAMPIRE DIARIES > AND THE SECRET CIRCLE 6829,6831c6829,6831 < >> THE VAMPIRE DIARIES < AND THE SECRET CIRCLE < ON THURSDAYS. --- > >> THE VAMPIRE DIARIES > AND THE SECRET CIRCLE > ON THURSDAYS. 6835c6835 < AND THE SECRET CIRCLE --- > AND THE SECRET CIRCLE ``` --- 🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

claunia added the pull-request label 2026-01-29 17:19:50 +00:00

claunia referenced this issue

2026-01-29 17:24:06 +00:00

[PR #2025] [MERGED] fix(avc): prevent segfault in report-only mode (-out=report) #2827

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#2025