[PR #1229] [FIX] Fix tags displaying incorrectly #2029

New Issue

claunia · 2026-01-29T17:19:51Z

claunia commented

2026-01-29 17:19:51 +00:00

Original Pull Request: https://github.com/CCExtractor/ccextractor/pull/1229

State: closed
Merged: Yes

This was caused by 19241744d7, moving from
unsigned char to enums for colors and fonts. The problem with this is
that each colour isn't one byte next to each other so memcpy and memset
didn't work anymore.

The problem:

6812,6813c6812,6813
< EDITION OF AMERICA'S NEXT TOP
< <i> MODEL</i> ON WEDNESDAYS.<i>          </i>
---
> EDITION OF<i> AMERICA'S NEXT TOP</i>
> <i> MODEL</i> ON WEDNESDAYS.
6817c6817
< EDITION OF AMERICA'S NEXT TOP
---
> EDITION OF<i> AMERICA'S NEXT TOP</i>
6819c6819
< >><i> THE VAMPIRE DIARIES         </i>
---
> >><i> THE VAMPIRE DIARIES</i>
6824,6825c6824,6825
< >><i> THE VA</i>MPIRE DIARIES
< AND<i> THE SECRET CIRCLE          </i>
---
> >><i> THE VAMPIRE DIARIES</i>
> AND<i> THE SECRET CIRCLE</i>
6829,6831c6829,6831
< >><i> THE VA</i>MPIRE DIARIES
< AND<i> THE S</i>ECRET CIRCLE
< ON THURSDAYS.<i>                  </i>
---
> >><i> THE VAMPIRE DIARIES</i>
> AND<i> THE SECRET CIRCLE</i>
> ON THURSDAYS.
6835c6835
< AND<i> THE S</i>ECRET CIRCLE
---
> AND<i> THE SECRET CIRCLE</i>

**Original Pull Request:** https://github.com/CCExtractor/ccextractor/pull/1229 **State:** closed **Merged:** Yes --- This was caused by 19241744d71adeda0f29c553b966236e88312c94, moving from `unsigned char` to `enums` for colors and fonts. The problem with this is that each colour isn't one byte next to each other so memcpy and memset didn't work anymore. The problem: ```patch 6812,6813c6812,6813 < EDITION OF AMERICA'S NEXT TOP < MODEL ON WEDNESDAYS. --- > EDITION OF AMERICA'S NEXT TOP > MODEL ON WEDNESDAYS. 6817c6817 < EDITION OF AMERICA'S NEXT TOP --- > EDITION OF AMERICA'S NEXT TOP 6819c6819 < >> THE VAMPIRE DIARIES --- > >> THE VAMPIRE DIARIES 6824,6825c6824,6825 < >> THE VAMPIRE DIARIES < AND THE SECRET CIRCLE --- > >> THE VAMPIRE DIARIES > AND THE SECRET CIRCLE 6829,6831c6829,6831 < >> THE VAMPIRE DIARIES < AND THE SECRET CIRCLE < ON THURSDAYS. --- > >> THE VAMPIRE DIARIES > AND THE SECRET CIRCLE > ON THURSDAYS. 6835c6835 < AND THE SECRET CIRCLE --- > AND THE SECRET CIRCLE ```

claunia added the pull-request label 2026-01-29 17:19:51 +00:00

claunia closed this issue

2026-01-29 17:19:51 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#2029