[PR #1233] [CLOSED] [FIX] MP4 (from itunes) files not being processed (no subs) (#1223) #2031

Open
opened 2026-01-29 17:19:52 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1233
Author: @sboronghosh
Created: 2/17/2020
Status: Closed

Base: masterHead: master


📝 Commits (2)

  • ca18502 [FIX] MP4 (from itunes) files not being processed (no subs)
  • 42afd9a Update CHANGES.TXT

📊 Changes

2 files changed (+182 additions, -115 deletions)

View changed files

📝 docs/CHANGES.TXT (+1 -0)
📝 src/thirdparty/gpacmp4/mp4.c (+181 -115)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Fixed the issue by regressing the changes, as discussed on the issue page, 0.85 release was working fine, on further investigation, 0.86 release was also correct. From 0.87 release, this issue started to pop up, so regressed the code back to 0.86 release for the full functionality.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1233 **Author:** [@sboronghosh](https://github.com/sboronghosh) **Created:** 2/17/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`ca18502`](https://github.com/CCExtractor/ccextractor/commit/ca18502c9b6f382e5ad2ecfec36edf50b2d88188) [FIX] MP4 (from itunes) files not being processed (no subs) - [`42afd9a`](https://github.com/CCExtractor/ccextractor/commit/42afd9aa78bd7ec1a700744efb04adf2d180c53f) Update CHANGES.TXT ### 📊 Changes **2 files changed** (+182 additions, -115 deletions) <details> <summary>View changed files</summary> 📝 `docs/CHANGES.TXT` (+1 -0) 📝 `src/thirdparty/gpacmp4/mp4.c` (+181 -115) </details> ### 📄 Description <!-- Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. --> **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [x] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [x] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- Fixed the issue by regressing the changes, as discussed on the issue page, 0.85 release was working fine, on further investigation, 0.86 release was also correct. From 0.87 release, this issue started to pop up, so regressed the code back to 0.86 release for the full functionality. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:19:52 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2031