[PR #1268] [MERGED] [FIX] Disable BOM in non-Windows build #2052

New Issue

claunia · 2026-01-29T17:20:03Z

claunia commented

2026-01-29 17:20:03 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1268
Author: @hamelg
Created: 5/9/2020
Status: ✅ Merged
Merged: 5/9/2020
Merged by: @cfsmp3

Base: master ← Head: GHA-01

📝 Commits (3)

088f4c3 Disable BOM in non-Windows build
3efab61 Disable BOM in non-Windows build
22537d9 Merge branch 'GHA-01' of github.com:hamelg/ccextractor into GHA-01

📊 Changes

1 file changed (+5 additions, -1 deletions)

View changed files

📝 src/lib_ccx/ccx_common_option.c (+5 -1)

📄 Description

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.
I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

about bom In the ccextractor help :


                 -bom: Append a BOM (Byte Order Mark) to output files.
                       Note that most text processing tools in linux will not
                       like BOM.
                       This is the default in Windows builds.
                       -nobom: Do not append a BOM (Byte Order Mark) to output
                       files. Note that this may break files when using
                       Windows. This is the default in non-Windows builds.

Currently, bom is also enabled in non-Windows builds. This PR fixes this issue.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1268 **Author:** [@hamelg](https://github.com/hamelg) **Created:** 5/9/2020 **Status:** ✅ Merged **Merged:** 5/9/2020 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `GHA-01` --- ### 📝 Commits (3) - [`088f4c3`](https://github.com/CCExtractor/ccextractor/commit/088f4c3bf132bfa3c3860d592b15b8dd84af9c10) Disable BOM in non-Windows build - [`3efab61`](https://github.com/CCExtractor/ccextractor/commit/3efab61346baf2a5610c2414763b5e64a8e0f690) Disable BOM in non-Windows build - [`22537d9`](https://github.com/CCExtractor/ccextractor/commit/22537d9e6161c3e19e802a1c3cd097735f5f4d36) Merge branch 'GHA-01' of github.com:hamelg/ccextractor into GHA-01 ### 📊 Changes **1 file changed** (+5 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/ccx_common_option.c` (+5 -1) </details> ### 📄 Description - [X] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [X] I have checked that another pull request for this purpose does not exist. - [X] I have considered, and confirmed that this submission will be valuable to others. - [X] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [X] I give this submission freely, and claim no ownership to its content. - [X] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [X] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- about bom In the ccextractor help : ``` -bom: Append a BOM (Byte Order Mark) to output files. Note that most text processing tools in linux will not like BOM. This is the default in Windows builds. -nobom: Do not append a BOM (Byte Order Mark) to output files. Note that this may break files when using Windows. This is the default in non-Windows builds. ``` Currently, bom is also enabled in non-Windows builds. This PR fixes this issue. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 17:20:03 +00:00

claunia referenced this issue

2026-01-29 17:24:18 +00:00

[PR #2052] [CLOSED] style: improve user-facing message for missing captions #2861

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#2052