[PR #1298] [CLOSED] [FIX] segmentation fault on encoding McPoodle's raw to WebVTT

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1298 **Author:** [@siv2r](https://github.com/siv2r) **Created:** 2/9/2021 **Status:** ❌ Closed **Base:** `master` ← **Head:** `webvtt-segfault-fix` --- ### 📝 Commits (1) - [`f95f435`](https://github.com/CCExtractor/ccextractor/commit/f95f435611d18b6f62cafc908b52147259c956d6) allocated space for context->timing ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/ccx_encoders_common.c` (+1 -0) </details> ### 📄 Description  **In raising this pull request, I confirm the following (please checkboxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [ ] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [x] I am an active contributor to CCExtractor. --- Fixes #1294 **Changes** The problem occurs in the initialization of the **encoder context**. The `malloc` function acts differently for `UK_ITVBE.ts` (here, `ctx->timing` is not null) and `cc_sample_dos2unix.bin` (here, `ctx->timing` is set to `null`) https://github.com/CCExtractor/ccextractor/blob/cf84757e02889ffa0231624fdf941eafded59906/src/lib_ccx/ccx_encoders_common.c#L935-L939 I added a fix by allocating memory for `ctx->timing.` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia commented

2026-01-29 17:20:10 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1298
Author: @siv2r
Created: 2/9/2021
Status: ❌ Closed

Base: master ← Head: webvtt-segfault-fix

📝 Commits (1)

f95f435 allocated space for context->timing

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 src/lib_ccx/ccx_encoders_common.c (+1 -0)

📄 Description

In raising this pull request, I confirm the following (please checkboxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.
I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

Fixes #1294

Changes
The problem occurs in the initialization of the encoder context. The malloc function acts differently for UK_ITVBE.ts (here, ctx->timing is not null) and cc_sample_dos2unix.bin (here, ctx->timing is set to null)
cf84757e02/src/lib_ccx/ccx_encoders_common.c (L935-L939)

I added a fix by allocating memory for ctx->timing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 17:20:10 +00:00

[PR #1298] [CLOSED] [FIX] segmentation fault on encoding McPoodle's raw to WebVTT #2076

📋 Pull Request Information

📝 Commits (1)

📊 Changes

📄 Description