[PR #1304] [MERGED] Ignore extra padding data in the current_packet #2084

Closed
opened 2026-01-29 17:20:12 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1304
Author: @PunitLodha
Created: 3/12/2021
Status: Merged
Merged: 4/5/2021
Merged by: @cfsmp3

Base: masterHead: 708_bug_fix


📝 Commits (2)

  • ca6c0df Ignore extra padding data in the current_packet
  • cd9227f refactor to avoid buffer overflow

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 src/lib_ccx/ccx_decoders_708.c (+3 -3)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Fixes issue #677
Instead of resetting the decoder, when current_length doesn't equal the len in header, change current_length to len(ignore the extra data as padding)


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1304 **Author:** [@PunitLodha](https://github.com/PunitLodha) **Created:** 3/12/2021 **Status:** ✅ Merged **Merged:** 4/5/2021 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `708_bug_fix` --- ### 📝 Commits (2) - [`ca6c0df`](https://github.com/CCExtractor/ccextractor/commit/ca6c0df7835fe14a14ea2befa7297d22304de276) Ignore extra padding data in the current_packet - [`cd9227f`](https://github.com/CCExtractor/ccextractor/commit/cd9227fce9b4e2b08798a44972af4b800e3f0845) refactor to avoid buffer overflow ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/ccx_decoders_708.c` (+3 -3) </details> ### 📄 Description <!-- Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. --> **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [ ] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [x] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- Fixes issue #677 Instead of resetting the decoder, when current_length doesn't equal the len in header, change current_length to len(ignore the extra data as padding) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:20:12 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2084