[PR #1331] [MERGED] [FIX] Removed extra lines of code which added extra p tags #2104

Open
opened 2026-01-29 17:20:19 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1331
Author: @SuvigyaJain1
Created: 5/1/2021
Status: Merged
Merged: 5/2/2021
Merged by: @cfsmp3

Base: masterHead: master


📝 Commits (2)

  • c482104 [FIX] Removed extra lines of code which added extra p tags
  • d770d8d [FIX] Removed extra lines of code which added extra p tags

📊 Changes

1 file changed (+1 additions, -8 deletions)

View changed files

📝 src/lib_ccx/ccx_encoders_smptett.c (+1 -8)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

So I couldn't find any sort of specification requiring empty p tags to be inserted into the ttml file. Thus I have removed the code that was adding these completely.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1331 **Author:** [@SuvigyaJain1](https://github.com/SuvigyaJain1) **Created:** 5/1/2021 **Status:** ✅ Merged **Merged:** 5/2/2021 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`c482104`](https://github.com/CCExtractor/ccextractor/commit/c482104e7b3687cb5b2eed60a21202868630a1ff) [FIX] Removed extra lines of code which added extra p tags - [`d770d8d`](https://github.com/CCExtractor/ccextractor/commit/d770d8dfda0ee235ff5188b525fe841fe621db92) [FIX] Removed extra lines of code which added extra p tags ### 📊 Changes **1 file changed** (+1 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/ccx_encoders_smptett.c` (+1 -8) </details> ### 📄 Description <!-- Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. --> **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [ ] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [x] I am an active contributor to CCExtractor. --- So I couldn't find any sort of specification requiring empty p tags to be inserted into the ttml file. Thus I have removed the code that was adding these completely. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:20:19 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2104