[PR #1332] [MERGED] [FIX] Multitrack, WebVTT, and Segfault issues

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1332 **Author:** [@emkman99](https://github.com/emkman99) **Created:** 5/5/2021 **Status:** ✅ Merged **Merged:** 5/19/2021 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (5) - [`12b9f93`](https://github.com/CCExtractor/ccextractor/commit/12b9f939fe55b34d88b54ec83a09013fad6ee62c) [FIX] Must have two newlines after WEBVTT header - [`6e19122`](https://github.com/CCExtractor/ccextractor/commit/6e191222a012d8fc9827ed4bf453532af4dd8bf3) [FIX] segfault with multitrack reports - [`57e6cd9`](https://github.com/CCExtractor/ccextractor/commit/57e6cd9ee12bea2d268bf6c419ec57cd07c7b117) [FIX] segfault with unsupported file reports - [`fc5074b`](https://github.com/CCExtractor/ccextractor/commit/fc5074befa8ab786fc0c49b3002568195d56dfa9) [FIX] Write subtitle header to multitrack outputs - [`c539fd0`](https://github.com/CCExtractor/ccextractor/commit/c539fd0856f1b5d8191a51d6e71dcc393f5574ee) [FIX] Write multitrack files to the output file directory ### 📊 Changes **5 files changed** (+27 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `docs/CHANGES.TXT` (+3 -0) 📝 `src/lib_ccx/ccx_encoders_common.c` (+16 -3) 📝 `src/lib_ccx/ccx_encoders_structs.h` (+1 -0) 📝 `src/lib_ccx/output.c` (+2 -0) 📝 `src/lib_ccx/params_dump.c` (+5 -0) </details> ### 📄 Description  **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [x] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [x] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- * The WEBVTT format issue was introduced in #1092 (after v0.88), so I didn't include it in the changelog. See [WebVTT file structure](https://www.w3.org/TR/webvtt1/#file-structure) for newline requirements. * Added the WEBVTT header to multitrack output files (mp4). * Generate multitrack filenames based on the output file instead of the input file. This fixes the situation where the -o argument is used and the first track is saved to the specified output location and the other tracks are saved next to the input file. I added `char *original_filename` to `struct ccx_s_write`, to avoid chained suffixes with three or more tracks (e.g. "test_2_3.vtt"). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia commented

2026-01-29 17:20:19 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1332
Author: @emkman99
Created: 5/5/2021
Status: ✅ Merged
Merged: 5/19/2021
Merged by: @cfsmp3

Base: master ← Head: master

📝 Commits (5)

12b9f93 [FIX] Must have two newlines after WEBVTT header
6e19122 [FIX] segfault with multitrack reports
57e6cd9 [FIX] segfault with unsupported file reports
fc5074b [FIX] Write subtitle header to multitrack outputs
c539fd0 [FIX] Write multitrack files to the output file directory

📊 Changes

5 files changed (+27 additions, -3 deletions)

View changed files

📝 docs/CHANGES.TXT (+3 -0)
📝 src/lib_ccx/ccx_encoders_common.c (+16 -3)
📝 src/lib_ccx/ccx_encoders_structs.h (+1 -0)
📝 src/lib_ccx/output.c (+2 -0)
📝 src/lib_ccx/params_dump.c (+5 -0)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.
I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

The WEBVTT format issue was introduced in #1092 (after v0.88), so I didn't include it in the changelog. See WebVTT file structure for newline requirements.
Added the WEBVTT header to multitrack output files (mp4).
Generate multitrack filenames based on the output file instead of the input file. This fixes the situation where the -o argument is used and the first track is saved to the specified output location and the other tracks are saved next to the input file. I added char *original_filename to struct ccx_s_write, to avoid chained suffixes with three or more tracks (e.g. "test_2_3.vtt").

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 17:20:19 +00:00

[PR #1332] [MERGED] [FIX] Multitrack, WebVTT, and Segfault issues #2106

📋 Pull Request Information

📝 Commits (5)

📊 Changes

📄 Description