[PR #1332] [FIX] Multitrack, WebVTT, and Segfault issues #2109

Closed
opened 2026-01-29 17:20:20 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/CCExtractor/ccextractor/pull/1332

State: closed
Merged: Yes


In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

  • The WEBVTT format issue was introduced in #1092 (after v0.88), so I didn't include it in the changelog. See WebVTT file structure for newline requirements.
  • Added the WEBVTT header to multitrack output files (mp4).
  • Generate multitrack filenames based on the output file instead of the input file. This fixes the situation where the -o argument is used and the first track is saved to the specified output location and the other tracks are saved next to the input file. I added char *original_filename to struct ccx_s_write, to avoid chained suffixes with three or more tracks (e.g. "test_2_3.vtt").
**Original Pull Request:** https://github.com/CCExtractor/ccextractor/pull/1332 **State:** closed **Merged:** Yes --- <!-- Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. --> **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [x] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [x] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- * The WEBVTT format issue was introduced in #1092 (after v0.88), so I didn't include it in the changelog. See [WebVTT file structure](https://www.w3.org/TR/webvtt1/#file-structure) for newline requirements. * Added the WEBVTT header to multitrack output files (mp4). * Generate multitrack filenames based on the output file instead of the input file. This fixes the situation where the -o argument is used and the first track is saved to the specified output location and the other tracks are saved next to the input file. I added `char *original_filename` to `struct ccx_s_write`, to avoid chained suffixes with three or more tracks (e.g. "test_2_3.vtt").
claunia added the pull-request label 2026-01-29 17:20:20 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2109