[PR #1341] [MERGED] [FIX] Attempt to fix long-running regression in TeleText #2114

Open
opened 2026-01-29 17:20:22 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1341
Author: @canihavesomecoffee
Created: 6/1/2021
Status: Merged
Merged: 6/10/2021
Merged by: @cfsmp3

Base: masterHead: bugfix/teletext-regression


📝 Commits (6)

📊 Changes

3 files changed (+8 additions, -2 deletions)

View changed files

📝 docs/CHANGES.TXT (+1 -0)
📝 src/lib_ccx/general_loop.c (+1 -1)
📝 src/lib_ccx/telxcc.c (+6 -1)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Regression test 78 (https://sampleplatform.ccextractor.org/regression/test/78/view)
has been broken since #622 was merged to fix other issues.

It's been traced back to be caused by not setting t0 at the correct time
(setting it using a calculated PTS time rather than taking it from the video frame),
and this commits attempts to fix that.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1341 **Author:** [@canihavesomecoffee](https://github.com/canihavesomecoffee) **Created:** 6/1/2021 **Status:** ✅ Merged **Merged:** 6/10/2021 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `bugfix/teletext-regression` --- ### 📝 Commits (6) - [`7c6e3db`](https://github.com/CCExtractor/ccextractor/commit/7c6e3db92e14f71e81080f6fbaa8a142d7c5d6b5) Attempt to fix long-running regression in TeleText - [`613047c`](https://github.com/CCExtractor/ccextractor/commit/613047c0b3574c3811d57d7311143f3c6ad0e8af) Add changes - [`c373d2c`](https://github.com/CCExtractor/ccextractor/commit/c373d2cc629beb544abd0ebc152880ded991d277) Clang-format changes - [`31f79f8`](https://github.com/CCExtractor/ccextractor/commit/31f79f809529b37aa524a64cb4a87aed34a345d7) Improved fix - [`54d241a`](https://github.com/CCExtractor/ccextractor/commit/54d241a307d5c9077a967ead384b5840e5a17041) Fixup - [`d5e2bb9`](https://github.com/CCExtractor/ccextractor/commit/d5e2bb920ca78e91fd8fce02c97acf47f293fcc0) Merge branch 'master' into bugfix/teletext-regression ### 📊 Changes **3 files changed** (+8 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `docs/CHANGES.TXT` (+1 -0) 📝 `src/lib_ccx/general_loop.c` (+1 -1) 📝 `src/lib_ccx/telxcc.c` (+6 -1) </details> ### 📄 Description **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [x] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [x] I am an active contributor to CCExtractor. Regression test 78 (https://sampleplatform.ccextractor.org/regression/test/78/view) has been broken since #622 was merged to fix other issues. It's been traced back to be caused by not setting t0 at the correct time (setting it using a calculated PTS time rather than taking it from the video frame), and this commits attempts to fix that. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:20:22 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2114