[PR #1350] [MERGED] Update function declarations and naming style #2120

Closed
opened 2026-01-29 17:20:24 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1350
Author: @PunitLodha
Created: 6/19/2021
Status: Merged
Merged: 6/19/2021
Merged by: @cfsmp3

Base: masterHead: naming_fix


📝 Commits (3)

  • 19dd322 Add declarations of functions and update names
  • aaf290f fix formating
  • ead7a8c update function signature for dtvcc_process_data

📊 Changes

11 files changed (+768 additions, -696 deletions)

View changed files

📝 src/lib_ccx/ccx_decoders_708.c (+379 -379)
📝 src/lib_ccx/ccx_decoders_708.h (+227 -163)
📝 src/lib_ccx/ccx_decoders_708_output.c (+65 -65)
📝 src/lib_ccx/ccx_decoders_708_output.h (+20 -4)
📝 src/lib_ccx/ccx_decoders_common.c (+7 -7)
📝 src/lib_ccx/ccx_decoders_structs.h (+1 -1)
📝 src/lib_ccx/ccx_dtvcc.c (+58 -64)
📝 src/lib_ccx/ccx_dtvcc.h (+4 -5)
📝 src/lib_ccx/ccx_encoders_common.c (+3 -3)
📝 src/lib_ccx/ccx_encoders_common.h (+3 -3)
📝 src/lib_ccx/mp4.c (+1 -2)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Add declarations for undeclared functions
Update naming style for all 708 related functions to have a consistent prefix of dtvcc_


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1350 **Author:** [@PunitLodha](https://github.com/PunitLodha) **Created:** 6/19/2021 **Status:** ✅ Merged **Merged:** 6/19/2021 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `naming_fix` --- ### 📝 Commits (3) - [`19dd322`](https://github.com/CCExtractor/ccextractor/commit/19dd322db00fe09dd9f74944dfc0e2e0841b8260) Add declarations of functions and update names - [`aaf290f`](https://github.com/CCExtractor/ccextractor/commit/aaf290f3aaaedc068f1d05f98fa0c8ebcb4d18b9) fix formating - [`ead7a8c`](https://github.com/CCExtractor/ccextractor/commit/ead7a8c6c72ca2313ca8cec02afd9f15c6006550) update function signature for dtvcc_process_data ### 📊 Changes **11 files changed** (+768 additions, -696 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/ccx_decoders_708.c` (+379 -379) 📝 `src/lib_ccx/ccx_decoders_708.h` (+227 -163) 📝 `src/lib_ccx/ccx_decoders_708_output.c` (+65 -65) 📝 `src/lib_ccx/ccx_decoders_708_output.h` (+20 -4) 📝 `src/lib_ccx/ccx_decoders_common.c` (+7 -7) 📝 `src/lib_ccx/ccx_decoders_structs.h` (+1 -1) 📝 `src/lib_ccx/ccx_dtvcc.c` (+58 -64) 📝 `src/lib_ccx/ccx_dtvcc.h` (+4 -5) 📝 `src/lib_ccx/ccx_encoders_common.c` (+3 -3) 📝 `src/lib_ccx/ccx_encoders_common.h` (+3 -3) 📝 `src/lib_ccx/mp4.c` (+1 -2) </details> ### 📄 Description <!-- Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. --> **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [ ] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [x] I am an active contributor to CCExtractor. --- Add declarations for undeclared functions Update naming style for all 708 related functions to have a consistent prefix of `dtvcc_` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:20:24 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2120