[PR #1359] [CLOSED] refactor: consistent param names #2135

New Issue

claunia · 2026-01-29T17:20:28Z

claunia commented

2026-01-29 17:20:28 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1359
Author: @techno-disaster
Created: 7/4/2021
Status: ❌ Closed

Base: master ← Head: td/consistent-param-names

📝 Commits (10+)

ab6caa5 make parameter spellings a bit more consistent
e7b0c21 better param names for strings
7f89cfe failed attempt at changing --out=sami to --out sami
04f96c2 fix inp and out
8eaadff parse outputfilename before out to avoid error
0b24ffd support prev version of params too
9f1b0ac revert windows/* files
bf1398b make params consistent for hardsubx
48f3300 fix: some params alternatives still had single -
4dca803 chore: update help menu

📊 Changes

1 file changed (+237 additions, -211 deletions)

View changed files

📝 src/lib_ccx/params.c (+237 -211)

📄 Description

Makes the parameter names a bit more consistent (--param name)
Also contains some autogenerated changes, should I remove those?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1359 **Author:** [@techno-disaster](https://github.com/techno-disaster) **Created:** 7/4/2021 **Status:** ❌ Closed **Base:** `master` ← **Head:** `td/consistent-param-names` --- ### 📝 Commits (10+) - [`ab6caa5`](https://github.com/CCExtractor/ccextractor/commit/ab6caa58d924a4596dd9b1d7c326415caf6ec531) make parameter spellings a bit more consistent - [`e7b0c21`](https://github.com/CCExtractor/ccextractor/commit/e7b0c2170badeddb3f81b734cce8414c891ecddf) better param names for strings - [`7f89cfe`](https://github.com/CCExtractor/ccextractor/commit/7f89cfe5c0d1880a6f4e01b6ad1b883c7999d5e2) failed attempt at changing --out=sami to --out sami - [`04f96c2`](https://github.com/CCExtractor/ccextractor/commit/04f96c221807d4445b8face7268f672d3721dc81) fix inp and out - [`8eaadff`](https://github.com/CCExtractor/ccextractor/commit/8eaadfff9a7ac4f8d4f0b878dd355841095e38e4) parse outputfilename before out to avoid error - [`0b24ffd`](https://github.com/CCExtractor/ccextractor/commit/0b24ffde88a73c09c0ba3eedd76ea2aac7e915d9) support prev version of params too - [`9f1b0ac`](https://github.com/CCExtractor/ccextractor/commit/9f1b0acdbe4ce3ab2a90734f5de0fd85166928b9) revert windows/* files - [`bf1398b`](https://github.com/CCExtractor/ccextractor/commit/bf1398b8b08371c7bb8578e79416bb883c77fe4e) make params consistent for hardsubx - [`48f3300`](https://github.com/CCExtractor/ccextractor/commit/48f3300c9677dcf8c67c2277734b0460a62ea743) fix: some params alternatives still had single - - [`4dca803`](https://github.com/CCExtractor/ccextractor/commit/4dca803cf44a2ab9e9de77ebb744247a1fb227e3) chore: update help menu ### 📊 Changes **1 file changed** (+237 additions, -211 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/params.c` (+237 -211) </details> ### 📄 Description Makes the parameter names a bit more consistent (--param name) Also contains some autogenerated changes, should I remove those? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 17:20:28 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#2135