[PR #1398] [MERGED] Extract 708 subs by default #2163

Closed
opened 2026-01-29 17:20:36 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1398
Author: @PunitLodha
Created: 12/5/2021
Status: Merged
Merged: 12/5/2021
Merged by: @cfsmp3

Base: masterHead: master


📝 Commits (2)

📊 Changes

7 files changed (+48 additions, -15 deletions)

View changed files

📝 docs/CHANGES.TXT (+1 -0)
📝 src/lib_ccx/ccx_common_option.c (+3 -0)
📝 src/lib_ccx/ccx_common_option.h (+3 -0)
📝 src/lib_ccx/ccx_decoders_608.c (+6 -2)
📝 src/lib_ccx/ccx_encoders_common.c (+1 -1)
📝 src/lib_ccx/mp4.c (+12 -12)
📝 src/lib_ccx/params.c (+22 -0)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Extract CEA-708 subs by default, without the need to pass any parameters.
Current status:-

  • 708(-svc) and field 1(-1) are enabled by default
  • if no params are provided:- extract whatever is available, if both(708 and 608) are available then extract both
  • If only -1/-2/-12 is provided:- extract only 608 subs
  • if only -svc is provided:- extract only 708 subs
  • if both -1/-2/-12 and -svc are provided:- extract both 608 and 708

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1398 **Author:** [@PunitLodha](https://github.com/PunitLodha) **Created:** 12/5/2021 **Status:** ✅ Merged **Merged:** 12/5/2021 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`e2bb023`](https://github.com/CCExtractor/ccextractor/commit/e2bb0237b0ad741fbddc8897ee069922669114ae) Extract 708 subs by default - [`3a9c0f7`](https://github.com/CCExtractor/ccextractor/commit/3a9c0f7672a7f2e557a74c29b36218cf35d16609) fix fmt ### 📊 Changes **7 files changed** (+48 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `docs/CHANGES.TXT` (+1 -0) 📝 `src/lib_ccx/ccx_common_option.c` (+3 -0) 📝 `src/lib_ccx/ccx_common_option.h` (+3 -0) 📝 `src/lib_ccx/ccx_decoders_608.c` (+6 -2) 📝 `src/lib_ccx/ccx_encoders_common.c` (+1 -1) 📝 `src/lib_ccx/mp4.c` (+12 -12) 📝 `src/lib_ccx/params.c` (+22 -0) </details> ### 📄 Description <!-- Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. --> **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [ ] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [x] I am an active contributor to CCExtractor. Extract CEA-708 subs by default, without the need to pass any parameters. Current status:- - 708(-svc) and field 1(-1) are enabled by default - if no params are provided:- extract whatever is available, if both(708 and 608) are available then extract both - If only -1/-2/-12 is provided:- extract only 608 subs - if only -svc is provided:- extract only 708 subs - if both -1/-2/-12 and -svc are provided:- extract both 608 and 708 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:20:36 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2163