[PR #1422] [MERGED] add option to extract closed captions and burnt in subs in the same pass #2174

New Issue

claunia · 2026-01-29T17:20:40Z

claunia commented

2026-01-29 17:20:40 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1422
Author: @shashwat1002
Created: 3/14/2022
Status: ✅ Merged
Merged: 3/27/2022
Merged by: @cfsmp3

Base: master ← Head: burnt_in_and_normal_subs

📝 Commits (3)

68d9303 [NEW] add functionality to allow extraction of cc and burnt-in subs in the same pass
fcc359c add change log
d7fe939 run clang formatter

📊 Changes

10 files changed (+542 additions, -216 deletions)

View changed files

📝 docs/CHANGES.TXT (+3 -0)
📝 src/ccextractor.c (+11 -12)
📝 src/lib_ccx/ccx_common_option.c (+1 -0)
📝 src/lib_ccx/ccx_common_option.h (+1 -0)
📝 src/lib_ccx/general_loop.c (+192 -163)
📝 src/lib_ccx/hardsubx.c (+15 -10)
📝 src/lib_ccx/hardsubx.h (+15 -13)
📝 src/lib_ccx/hardsubx_decoder.c (+278 -9)
📝 src/lib_ccx/lib_ccx.h (+9 -0)
📝 src/lib_ccx/params.c (+17 -9)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.
[] I have mentioned this change in the changelog.
(Not applicable because still WIP)

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

This PR is in context to issue #726

The current status is that the generated subtitle file has content from closed-caption extraction and burnt-in extraction, however they are not in the correct order.

The approach I have in mind right now is to use the timestamp of previously encoded subtitles of one of the modes (burnt-in or closed caption) and make a decision on which packet to process (the image or the closed caption)

Please advise on whether this approach looks okay.

Note: I have added appropriate command line options for this already

Any advice is appreciated

CC: @cfsmp3

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1422 **Author:** [@shashwat1002](https://github.com/shashwat1002) **Created:** 3/14/2022 **Status:** ✅ Merged **Merged:** 3/27/2022 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `burnt_in_and_normal_subs` --- ### 📝 Commits (3) - [`68d9303`](https://github.com/CCExtractor/ccextractor/commit/68d9303de01c95bd1ace960c12cdd2fdd5ce3354) [NEW] add functionality to allow extraction of cc and burnt-in subs in the same pass - [`fcc359c`](https://github.com/CCExtractor/ccextractor/commit/fcc359c96fadea6e44318c3e698a2713642ce582) add change log - [`d7fe939`](https://github.com/CCExtractor/ccextractor/commit/d7fe93952ee030883ef276c5350687e1bf2fed7a) run clang formatter ### 📊 Changes **10 files changed** (+542 additions, -216 deletions) <details> <summary>View changed files</summary> 📝 `docs/CHANGES.TXT` (+3 -0) 📝 `src/ccextractor.c` (+11 -12) 📝 `src/lib_ccx/ccx_common_option.c` (+1 -0) 📝 `src/lib_ccx/ccx_common_option.h` (+1 -0) 📝 `src/lib_ccx/general_loop.c` (+192 -163) 📝 `src/lib_ccx/hardsubx.c` (+15 -10) 📝 `src/lib_ccx/hardsubx.h` (+15 -13) 📝 `src/lib_ccx/hardsubx_decoder.c` (+278 -9) 📝 `src/lib_ccx/lib_ccx.h` (+9 -0) 📝 `src/lib_ccx/params.c` (+17 -9) </details> ### 📄 Description  **In raising this pull request, I confirm the following (please check boxes):** - [X] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [X] I have checked that another pull request for this purpose does not exist. - [X] I have considered, and confirmed that this submission will be valuable to others. - [X] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [X] I give this submission freely, and claim no ownership to its content. - [] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** (Not applicable because still WIP) **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [X] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- This PR is in context to issue #726 The current status is that the generated subtitle file has content from closed-caption extraction and burnt-in extraction, however they are not in the correct order. The approach I have in mind right now is to use the timestamp of previously encoded subtitles of one of the modes (burnt-in or closed caption) and make a decision on which packet to process (the image or the closed caption) Please advise on whether this approach looks okay. Note: I have added appropriate command line options for this already Any advice is appreciated CC: @cfsmp3 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 17:20:40 +00:00

claunia closed this issue

2026-01-29 17:20:40 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#2174