[PR #1454] [CLOSED] [WIP] attempt compatibility with ffmpeg #2192

New Issue

claunia · 2026-01-29T17:20:46Z

claunia commented

2026-01-29 17:20:46 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1454
Author: @shashwat1002
Created: 9/26/2022
Status: ❌ Closed

Base: master ← Head: ffmpeg5_compat

📝 Commits (4)

e7e3bc3 add lib_hardsubx_ctx struct to mod.rs of hardsubx
df0b9c5 take care of external dependencies and general bindings
25620dd make code_ctx of the AVCodecParameters type of ffmpeg for ffmpeg5 comatibility
9cc7b3a main code and hide hardsubx_process_data's C version. The linker fucks up rn

📊 Changes

8 files changed (+503 additions, -11 deletions)

View changed files

📝 src/lib_ccx/hardsubx.c (+2 -0)
📝 src/rust/Cargo.lock (+58 -4)
📝 src/rust/Cargo.toml (+5 -2)
📝 src/rust/build.rs (+15 -4)
➕ src/rust/src/hardsubx/main.rs (+256 -0)
📝 src/rust/src/hardsubx/mod.rs (+163 -0)
📝 src/rust/src/lib.rs (+1 -1)
📝 src/rust/wrapper.h (+3 -0)

📄 Description

This is the work for compatibility with ffmpeg. The current problem is that certain hardsubx functions on the C side are not discoverable by the linker when Rust code tries to call them.

I think eventually I will have to close this PR and PR #1446 and have the common changes in a third PR that'll be easier than dealing with the merge conflicts.

Because this has taken far too much time, I'll roll back to ffmpeg 4 for now and continue porting. I really wanted to deal with this before.

PS: Pardon the impolite commit language. I plan to clean up the commit history
cc: @PunitLodha @cfsmp3

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1454 **Author:** [@shashwat1002](https://github.com/shashwat1002) **Created:** 9/26/2022 **Status:** ❌ Closed **Base:** `master` ← **Head:** `ffmpeg5_compat` --- ### 📝 Commits (4) - [`e7e3bc3`](https://github.com/CCExtractor/ccextractor/commit/e7e3bc3ef310d56e73b392b03b86cfe560794777) add lib_hardsubx_ctx struct to mod.rs of hardsubx - [`df0b9c5`](https://github.com/CCExtractor/ccextractor/commit/df0b9c501084880436bb29661c5793e71a5344a3) take care of external dependencies and general bindings - [`25620dd`](https://github.com/CCExtractor/ccextractor/commit/25620ddf7f319af3251e7db2992e77ebf7975689) make code_ctx of the AVCodecParameters type of ffmpeg for ffmpeg5 comatibility - [`9cc7b3a`](https://github.com/CCExtractor/ccextractor/commit/9cc7b3a7c4993ccd30c67bae9fe779ecc2409e98) main code and hide hardsubx_process_data's C version. The linker fucks up rn ### 📊 Changes **8 files changed** (+503 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/hardsubx.c` (+2 -0) 📝 `src/rust/Cargo.lock` (+58 -4) 📝 `src/rust/Cargo.toml` (+5 -2) 📝 `src/rust/build.rs` (+15 -4) ➕ `src/rust/src/hardsubx/main.rs` (+256 -0) 📝 `src/rust/src/hardsubx/mod.rs` (+163 -0) 📝 `src/rust/src/lib.rs` (+1 -1) 📝 `src/rust/wrapper.h` (+3 -0) </details> ### 📄 Description This is the work for compatibility with ffmpeg. The current problem is that certain hardsubx functions on the C side are not discoverable by the linker when Rust code tries to call them. I think eventually I will have to close this PR and PR #1446 and have the common changes in a third PR that'll be easier than dealing with the merge conflicts. Because this has taken far too much time, I'll roll back to ffmpeg 4 for now and continue porting. I really wanted to deal with this before. PS: Pardon the impolite commit language. I plan to clean up the commit history cc: @PunitLodha @cfsmp3 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 17:20:46 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#2192