[PR #1460] [MERGED] [FIX] Fix issue #1453: Respect -stdout if multiple CC tracks are found in a Matroska input file #2199

Open
opened 2026-01-29 17:20:48 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1460
Author: @abhi-kr-2100
Created: 11/24/2022
Status: Merged
Merged: 12/14/2022
Merged by: @cfsmp3

Base: masterHead: fix-issue-1453


📝 Commits (3)

  • 7c58087 Respect -stdout if multiple CC tracks are found
  • 1f0eb85 Mention fixing of issue #1453 in changelog
  • 7f91df5 Correctly spell Matroska

📊 Changes

2 files changed (+15 additions, -5 deletions)

View changed files

📝 docs/CHANGES.TXT (+1 -0)
📝 src/lib_ccx/matroska.c (+14 -5)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

When passed the -stdout flag, CCExtractor should write the subtitles to standard output, instead of an output file.

However, as noted in Issue #1453, CCExtractor doesn't respect the -stdout flag when multiple CC tracks are present in a Matroska input file (usually .mkv).

The commit/s in this pull request ensure/s that output is written to standard output if -stdout is present even if the input file is a Matroska container with multiple CC tracks.

Signed-off-by: Abhishek Kumar abhi.kr.2100@gmail.com


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1460 **Author:** [@abhi-kr-2100](https://github.com/abhi-kr-2100) **Created:** 11/24/2022 **Status:** ✅ Merged **Merged:** 12/14/2022 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `fix-issue-1453` --- ### 📝 Commits (3) - [`7c58087`](https://github.com/CCExtractor/ccextractor/commit/7c58087637013053aab279be09e23de9e29481c7) Respect `-stdout` if multiple CC tracks are found - [`1f0eb85`](https://github.com/CCExtractor/ccextractor/commit/1f0eb852b269a01e5cc374ef26db060d42f9b7d3) Mention fixing of issue #1453 in changelog - [`7f91df5`](https://github.com/CCExtractor/ccextractor/commit/7f91df5403ff4fcf58461ae0d9ef559f10ea6c6e) Correctly spell Matroska ### 📊 Changes **2 files changed** (+15 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `docs/CHANGES.TXT` (+1 -0) 📝 `src/lib_ccx/matroska.c` (+14 -5) </details> ### 📄 Description <!-- Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. --> **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [x] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [x] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- When passed the `-stdout` flag, CCExtractor should write the subtitles to standard output, instead of an output file. However, as noted in Issue #1453, CCExtractor doesn't respect the `-stdout` flag when multiple CC tracks are present in a Matroska input file (usually .mkv). The commit/s in this pull request ensure/s that output is written to standard output if `-stdout` is present even if the input file is a Matroska container with multiple CC tracks. Signed-off-by: Abhishek Kumar <abhi.kr.2100@gmail.com> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:20:48 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2199