[PR #1464] [MERGED] [FIX] WebVTT X-TIMESTAMP-MAP header placement (#1463)

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1464 **Author:** [@emkman99](https://github.com/emkman99) **Created:** 12/13/2022 **Status:** ✅ Merged **Merged:** 12/14/2022 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `timestamp-map` --- ### 📝 Commits (4) - [`e10e4e4`](https://github.com/CCExtractor/ccextractor/commit/e10e4e40e3b09b026184cb06fb36e9ef19506422) [FIX] WebVTT X-TIMESTAMP-MAP header placement (#1463) - [`130b374`](https://github.com/CCExtractor/ccextractor/commit/130b374113f3d4cb6bf60a82740da206b2c4a7ec) Fixed --no-timestamp-map flag - [`9ae9da9`](https://github.com/CCExtractor/ccextractor/commit/9ae9da9a265bfeacfae5d1d924b88dd56e8f95dc) Disable X-TIMESTAMP-MAP by default - [`3d8cac3`](https://github.com/CCExtractor/ccextractor/commit/3d8cac395047b13a006807a76534082db67097c2) Write second WebVTT newline when timing info is missing ### 📊 Changes **7 files changed** (+26 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `docs/CHANGES.TXT` (+2 -1) 📝 `src/lib_ccx/ccx_common_option.c` (+1 -1) 📝 `src/lib_ccx/ccx_common_option.h` (+1 -2) 📝 `src/lib_ccx/ccx_encoders_common.c` (+1 -2) 📝 `src/lib_ccx/ccx_encoders_common.h` (+0 -2) 📝 `src/lib_ccx/ccx_encoders_webvtt.c` (+18 -8) 📝 `src/lib_ccx/params.c` (+3 -3) </details> ### 📄 Description  **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [x] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [x] I am an active contributor to CCExtractor. --- This fixes issue #1463. If enabled, the X-TIMESTAMP-MAP header is placed on the second line. There are always two newlines between the headers and body. This also fixes the --no-timestamp-map option, which wasn't disabling the header. I added on the commit to disable X-TIMESTAMP-MAP header by default since it is not valid WebVTT. It doesn't make sense to generate invalid WebVTT by default, especially when the input is not MPEG-TS. This is a breaking change (--no-timestamp-map becomes --timestamp-map). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia commented

2026-01-29 17:20:48 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1464
Author: @emkman99
Created: 12/13/2022
Status: ✅ Merged
Merged: 12/14/2022
Merged by: @cfsmp3

Base: master ← Head: timestamp-map

📝 Commits (4)

e10e4e4 [FIX] WebVTT X-TIMESTAMP-MAP header placement (#1463)
130b374 Fixed --no-timestamp-map flag
9ae9da9 Disable X-TIMESTAMP-MAP by default
3d8cac3 Write second WebVTT newline when timing info is missing

📊 Changes

7 files changed (+26 additions, -19 deletions)

View changed files

📝 docs/CHANGES.TXT (+2 -1)
📝 src/lib_ccx/ccx_common_option.c (+1 -1)
📝 src/lib_ccx/ccx_common_option.h (+1 -2)
📝 src/lib_ccx/ccx_encoders_common.c (+1 -2)
📝 src/lib_ccx/ccx_encoders_common.h (+0 -2)
📝 src/lib_ccx/ccx_encoders_webvtt.c (+18 -8)
📝 src/lib_ccx/params.c (+3 -3)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.
I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

This fixes issue #1463. If enabled, the X-TIMESTAMP-MAP header is placed on the second line. There are always two newlines between the headers and body.

This also fixes the --no-timestamp-map option, which wasn't disabling the header.

I added on the commit to disable X-TIMESTAMP-MAP header by default since it is not valid WebVTT. It doesn't make sense to generate invalid WebVTT by default, especially when the input is not MPEG-TS. This is a breaking change (--no-timestamp-map becomes --timestamp-map).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 17:20:48 +00:00

[PR #1464] [MERGED] [FIX] WebVTT X-TIMESTAMP-MAP header placement (#1463) #2200

📋 Pull Request Information

📝 Commits (4)

📊 Changes

📄 Description