mirror of
https://github.com/CCExtractor/ccextractor.git
synced 2026-04-18 03:52:46 +00:00
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Original Pull Request: https://github.com/CCExtractor/ccextractor/pull/1464
State: closed
Merged: Yes
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
This fixes issue #1463. If enabled, the X-TIMESTAMP-MAP header is placed on the second line. There are always two newlines between the headers and body.
This also fixes the --no-timestamp-map option, which wasn't disabling the header.
I added on the commit to disable X-TIMESTAMP-MAP header by default since it is not valid WebVTT. It doesn't make sense to generate invalid WebVTT by default, especially when the input is not MPEG-TS. This is a breaking change (--no-timestamp-map becomes --timestamp-map).