[PR #1480] [MERGED] [IMPROVEMENT] Update Rust and fix windows build #2210

Closed
opened 2026-01-29 17:20:52 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1480
Author: @prateekmedia
Created: 2/16/2023
Status: Merged
Merged: 3/12/2023
Merged by: @cfsmp3

Base: masterHead: patch-1


📝 Commits (10+)

  • 5b442a8 fix: bump leptonica-sys to 0.4.3 and update Cargo.lock
  • 5fe6e7c fix: bump rust version to 1.57.0 and build vcpkg for window hardsubx builds
  • 2834fcc fix: add Bcrypt dependency
  • 3f3d36e fix: switch to rust stable
  • d3e5cea chore: bump package versions
  • ee5694b fix: try to remove i686 to fix error
  • d999093 fix: install tesseract and lint fixes
  • 1778dab fix: try using ffmpeg the third
  • 179c399 fix: include headers
  • 4acfbf8 fix: add rsmpeg

📊 Changes

181 files changed (+793 additions, -34787 deletions)

View changed files

📝 .github/workflows/build_linux.yml (+10 -4)
📝 .github/workflows/build_windows.yml (+59 -22)
📝 .github/workflows/format.yml (+6 -3)
📝 .github/workflows/release.yml (+2 -3)
📝 .gitignore (+4 -0)
📝 src/CMakeLists.txt (+1 -1)
📝 src/lib_ccx/ccx_encoders_helpers.h (+5 -4)
📝 src/lib_ccx/ccx_encoders_sami.c (+1 -1)
📝 src/lib_ccx/ccx_encoders_smptett.c (+1 -1)
📝 src/lib_ccx/ccx_encoders_spupng.c (+1 -1)
📝 src/lib_ccx/ocr.c (+9 -4)
📝 src/lib_ccx/params.c (+3 -3)
📝 src/rust/Cargo.lock (+234 -161)
📝 src/rust/Cargo.toml (+4 -4)
📝 src/rust/src/decoder/service_decoder.rs (+1 -1)
📝 src/rust/src/hardsubx/decoder.rs (+1 -1)
📝 src/rust/src/hardsubx/mod.rs (+3 -1)
📝 src/rust/src/hardsubx/utility.rs (+6 -4)
📝 src/thirdparty/lib_hash/sha2.c (+39 -39)
📝 src/thirdparty/lib_hash/sha2.h (+30 -30)

...and 80 more files

📄 Description

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

  • Update Rust to stable (done)
  • Switch to rusty_ffmpeg and rsmpeg from ffmpeg-sys-next
  • Fix windows CI (add support of vcpkg for static linking and supporting both architectures)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1480 **Author:** [@prateekmedia](https://github.com/prateekmedia) **Created:** 2/16/2023 **Status:** ✅ Merged **Merged:** 3/12/2023 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (10+) - [`5b442a8`](https://github.com/CCExtractor/ccextractor/commit/5b442a8c0a6f3db017eeadb29c4c1f98e05c559b) fix: bump leptonica-sys to 0.4.3 and update Cargo.lock - [`5fe6e7c`](https://github.com/CCExtractor/ccextractor/commit/5fe6e7caf829b9721a7e4b24c3251619c1297390) fix: bump rust version to 1.57.0 and build vcpkg for window hardsubx builds - [`2834fcc`](https://github.com/CCExtractor/ccextractor/commit/2834fccdc7d31935ca2f6e2613b2c237dc627d5a) fix: add Bcrypt dependency - [`3f3d36e`](https://github.com/CCExtractor/ccextractor/commit/3f3d36e4edbdcc22f98383b1d924b9dddcd94475) fix: switch to rust stable - [`d3e5cea`](https://github.com/CCExtractor/ccextractor/commit/d3e5cea6aec36458b25c5a64579c7172639ac645) chore: bump package versions - [`ee5694b`](https://github.com/CCExtractor/ccextractor/commit/ee5694bd6a8c3c9965198ffb4cf59c3b4b5efc1f) fix: try to remove i686 to fix error - [`d999093`](https://github.com/CCExtractor/ccextractor/commit/d9990935a1fca78bfb6dc85275b5542667d97093) fix: install tesseract and lint fixes - [`1778dab`](https://github.com/CCExtractor/ccextractor/commit/1778dab3c386b5880fe2390ac17c0c361ed03afc) fix: try using ffmpeg the third - [`179c399`](https://github.com/CCExtractor/ccextractor/commit/179c3995d1d2338d17d2f35fbe1021d43bac337d) fix: include headers - [`4acfbf8`](https://github.com/CCExtractor/ccextractor/commit/4acfbf8c6f1151407a13cf4487f4bde55ff7d724) fix: add rsmpeg ### 📊 Changes **181 files changed** (+793 additions, -34787 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build_linux.yml` (+10 -4) 📝 `.github/workflows/build_windows.yml` (+59 -22) 📝 `.github/workflows/format.yml` (+6 -3) 📝 `.github/workflows/release.yml` (+2 -3) 📝 `.gitignore` (+4 -0) 📝 `src/CMakeLists.txt` (+1 -1) 📝 `src/lib_ccx/ccx_encoders_helpers.h` (+5 -4) 📝 `src/lib_ccx/ccx_encoders_sami.c` (+1 -1) 📝 `src/lib_ccx/ccx_encoders_smptett.c` (+1 -1) 📝 `src/lib_ccx/ccx_encoders_spupng.c` (+1 -1) 📝 `src/lib_ccx/ocr.c` (+9 -4) 📝 `src/lib_ccx/params.c` (+3 -3) 📝 `src/rust/Cargo.lock` (+234 -161) 📝 `src/rust/Cargo.toml` (+4 -4) 📝 `src/rust/src/decoder/service_decoder.rs` (+1 -1) 📝 `src/rust/src/hardsubx/decoder.rs` (+1 -1) 📝 `src/rust/src/hardsubx/mod.rs` (+3 -1) 📝 `src/rust/src/hardsubx/utility.rs` (+6 -4) 📝 `src/thirdparty/lib_hash/sha2.c` (+39 -39) 📝 `src/thirdparty/lib_hash/sha2.h` (+30 -30) _...and 80 more files_ </details> ### 📄 Description <!-- Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. --> **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [ ] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [x] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- - Update Rust to stable (done) - Switch to `rusty_ffmpeg` and `rsmpeg` from `ffmpeg-sys-next` - Fix windows CI (add support of vcpkg for static linking and supporting both architectures) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:20:52 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2210