[PR #1486] [MERGED] [FIX] Missing # in color attribute of font tag #2213

New Issue

claunia · 2026-01-29T17:20:53Z

claunia commented

2026-01-29 17:20:53 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1486
Author: @elbertronnie
Created: 3/7/2023
Status: ✅ Merged
Merged: 3/7/2023
Merged by: @cfsmp3

Base: master ← Head: fix-missing-hash

📝 Commits (1)

a245d4e Fix missing # in color attribute of font tag

📊 Changes

3 files changed (+3 additions, -2 deletions)

View changed files

📝 docs/CHANGES.TXT (+1 -0)
📝 src/lib_ccx/ccx_decoders_708_output.c (+1 -1)
📝 src/rust/src/decoder/tv_screen.rs (+1 -1)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.
I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

Link to sample video: https://drive.google.com/file/d/13p6HBxGXlm0BGpaS15JwCJjfnBdm_Qbm/view?usp=sharing
Running ccextractor on the above sample video WhackedOutVideos_short.mov produces a file WhackedOutVideos_short.p0.svc01.srt with the following contents:

1
00:00:02,502 --> 00:00:03,636
<font color="aaaaaa">Or is this synchronized</font>

2
00:00:03,637 --> 00:00:05,971
<font color="aaaaaa">Or is this synchronized</font>
<font color="aaaaaa">stick poking?</font>

.
.
.

Without the # in color attribute of font tag, the text is rendered by black color instead of #aaaaaa. This PR adds the missing #:

1
00:00:02,502 --> 00:00:03,636
<font color="#aaaaaa">Or is this synchronized</font>

2
00:00:03,637 --> 00:00:05,971
<font color="#aaaaaa">Or is this synchronized</font>
<font color="#aaaaaa">stick poking?</font>

.
.
.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1486 **Author:** [@elbertronnie](https://github.com/elbertronnie) **Created:** 3/7/2023 **Status:** ✅ Merged **Merged:** 3/7/2023 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `fix-missing-hash` --- ### 📝 Commits (1) - [`a245d4e`](https://github.com/CCExtractor/ccextractor/commit/a245d4e666936e129002f6544a6c7d79f40c55af) Fix missing `#` in color attribute of font tag ### 📊 Changes **3 files changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `docs/CHANGES.TXT` (+1 -0) 📝 `src/lib_ccx/ccx_decoders_708_output.c` (+1 -1) 📝 `src/rust/src/decoder/tv_screen.rs` (+1 -1) </details> ### 📄 Description  **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [x] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [x] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- Link to sample video: https://drive.google.com/file/d/13p6HBxGXlm0BGpaS15JwCJjfnBdm_Qbm/view?usp=sharing Running ccextractor on the above sample video WhackedOutVideos_short.mov produces a file WhackedOutVideos_short.p0.svc01.srt with the following contents: ``` 1 00:00:02,502 --> 00:00:03,636 Or is this synchronized 2 00:00:03,637 --> 00:00:05,971 Or is this synchronized stick poking? . . . ``` Without the `#` in color attribute of font tag, the text is rendered by black color instead of `#aaaaaa`. This PR adds the missing `#`: ``` 1 00:00:02,502 --> 00:00:03,636 Or is this synchronized 2 00:00:03,637 --> 00:00:05,971 Or is this synchronized stick poking? . . . ``` --- 🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

claunia added the pull-request label 2026-01-29 17:20:53 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#2213

[PR #1486] [MERGED] [FIX] Missing # in color attribute of font tag #2213

📋 Pull Request Information

📝 Commits (1)

📊 Changes

📄 Description

[PR #1486] [MERGED] [FIX] Missing `#` in color attribute of font tag #2213