[PR #1486] [FIX] Missing # in color attribute of font tag #2216

New Issue

claunia · 2026-01-29T17:20:53Z

claunia commented

2026-01-29 17:20:53 +00:00

Original Pull Request: https://github.com/CCExtractor/ccextractor/pull/1486

State: closed
Merged: Yes

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.
I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

Link to sample video: https://drive.google.com/file/d/13p6HBxGXlm0BGpaS15JwCJjfnBdm_Qbm/view?usp=sharing
Running ccextractor on the above sample video WhackedOutVideos_short.mov produces a file WhackedOutVideos_short.p0.svc01.srt with the following contents:

1
00:00:02,502 --> 00:00:03,636
<font color="aaaaaa">Or is this synchronized</font>

2
00:00:03,637 --> 00:00:05,971
<font color="aaaaaa">Or is this synchronized</font>
<font color="aaaaaa">stick poking?</font>

.
.
.

Without the # in color attribute of font tag, the text is rendered by black color instead of #aaaaaa. This PR adds the missing #:

1
00:00:02,502 --> 00:00:03,636
<font color="#aaaaaa">Or is this synchronized</font>

2
00:00:03,637 --> 00:00:05,971
<font color="#aaaaaa">Or is this synchronized</font>
<font color="#aaaaaa">stick poking?</font>

.
.
.

**Original Pull Request:** https://github.com/CCExtractor/ccextractor/pull/1486 **State:** closed **Merged:** Yes ---  **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [x] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [x] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- Link to sample video: https://drive.google.com/file/d/13p6HBxGXlm0BGpaS15JwCJjfnBdm_Qbm/view?usp=sharing Running ccextractor on the above sample video WhackedOutVideos_short.mov produces a file WhackedOutVideos_short.p0.svc01.srt with the following contents: ``` 1 00:00:02,502 --> 00:00:03,636 Or is this synchronized 2 00:00:03,637 --> 00:00:05,971 Or is this synchronized stick poking? . . . ``` Without the `#` in color attribute of font tag, the text is rendered by black color instead of `#aaaaaa`. This PR adds the missing `#`: ``` 1 00:00:02,502 --> 00:00:03,636 Or is this synchronized 2 00:00:03,637 --> 00:00:05,971 Or is this synchronized stick poking? . . . ```

claunia added the pull-request label 2026-01-29 17:20:53 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#2216

[PR #1486] [FIX] Missing # in color attribute of font tag #2216

[PR #1486] [FIX] Missing `#` in color attribute of font tag #2216