[PR #1501] [CLOSED] [WIP] [FIX] #1499 Persistent `Dtvcc` struct for CEA-708 decoding in Rust

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1501 **Author:** [@ArchitBhonsle](https://github.com/ArchitBhonsle) **Created:** 3/16/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `rust-persistent-dtvcc` --- ### 📝 Commits (10+) - [`395a873`](https://github.com/CCExtractor/ccextractor/commit/395a873afae317de5bd973229077b0cb69accbc5) Rewriting `Dtvcc::new()` to instantiate - [`5e72dff`](https://github.com/CCExtractor/ccextractor/commit/5e72dffef1553dca588c876ec775c1343d61af73) Moving raw pointers to `Option`s and `Vec`s to arrays - [`9ff02b9`](https://github.com/CCExtractor/ccextractor/commit/9ff02b9cc137b7dc48809f7b3fe6976173b11bad) Questionable implementation of `ccxr_dtvcc_free` - [`7a0a2fd`](https://github.com/CCExtractor/ccextractor/commit/7a0a2fd5ce749334da74c478bc88c173005eaf98) Helpful comments - [`20271f6`](https://github.com/CCExtractor/ccextractor/commit/20271f6dfa27cc064e9d4fb9d28b00110287dbab) Modifying `lib_cc_decode` (C) to use the new `Dtvcc` (Rust) - [`4b08981`](https://github.com/CCExtractor/ccextractor/commit/4b089815a34acfd15617a074fcafdde04432c1de) Silencing clippy - [`44141b1`](https://github.com/CCExtractor/ccextractor/commit/44141b14aedfe3cfee6edcdbdf238753954cc908) Setting the encoder from C - [`125e740`](https://github.com/CCExtractor/ccextractor/commit/125e74036c6349eb57062a9d3cd2ed3bb9d39819) Storing pointers over references and `Box`ing the decoders - [`e42fe35`](https://github.com/CCExtractor/ccextractor/commit/e42fe3527892b6f9a213e60a552ad50e2d8b9348) Switching over the encoder assignment based on `DISABLE RUST` - [`22f5684`](https://github.com/CCExtractor/ccextractor/commit/22f568451de4954cb70f467fcd8ff1b383e9ae9b) Exporting `ccxr_process_data` from Rust and using in `mp4.c` ### 📊 Changes **10 files changed** (+212 additions, -50 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+2 -1) 📝 `src/lib_ccx/ccx_decoders_common.c` (+8 -0) 📝 `src/lib_ccx/ccx_decoders_structs.h` (+1 -0) 📝 `src/lib_ccx/general_loop.c` (+16 -0) 📝 `src/lib_ccx/mp4.c` (+10 -0) 📝 `src/rust/build.rs` (+1 -0) 📝 `src/rust/src/decoder/mod.rs` (+118 -35) 📝 `src/rust/src/decoder/tv_screen.rs` (+4 -4) 📝 `src/rust/src/decoder/window.rs` (+6 -6) 📝 `src/rust/src/lib.rs` (+46 -4) </details> ### 📄 Description **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [ ] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [x] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- {pull request content here} --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia commented

2026-01-29 17:20:57 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1501
Author: @ArchitBhonsle
Created: 3/16/2023
Status: ❌ Closed

Base: master ← Head: rust-persistent-dtvcc

📝 Commits (10+)

395a873 Rewriting Dtvcc::new() to instantiate
5e72dff Moving raw pointers to Options and Vecs to arrays
9ff02b9 Questionable implementation of ccxr_dtvcc_free
7a0a2fd Helpful comments
20271f6 Modifying lib_cc_decode (C) to use the new Dtvcc (Rust)
4b08981 Silencing clippy
44141b1 Setting the encoder from C
125e740 Storing pointers over references and Boxing the decoders
e42fe35 Switching over the encoder assignment based on DISABLE RUST
22f5684 Exporting ccxr_process_data from Rust and using in mp4.c

📊 Changes

10 files changed (+212 additions, -50 deletions)

View changed files

📝 .gitignore (+2 -1)
📝 src/lib_ccx/ccx_decoders_common.c (+8 -0)
📝 src/lib_ccx/ccx_decoders_structs.h (+1 -0)
📝 src/lib_ccx/general_loop.c (+16 -0)
📝 src/lib_ccx/mp4.c (+10 -0)
📝 src/rust/build.rs (+1 -0)
📝 src/rust/src/decoder/mod.rs (+118 -35)
📝 src/rust/src/decoder/tv_screen.rs (+4 -4)
📝 src/rust/src/decoder/window.rs (+6 -6)
📝 src/rust/src/lib.rs (+46 -4)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.
I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

{pull request content here}

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 17:20:57 +00:00

[PR #1501] [CLOSED] [WIP] [FIX] #1499 Persistent Dtvcc struct for CEA-708 decoding in Rust #2224

📋 Pull Request Information

📝 Commits (10+)

📊 Changes

📄 Description

[PR #1501] [CLOSED] [WIP] [FIX] #1499 Persistent `Dtvcc` struct for CEA-708 decoding in Rust #2224