[PR #1497] [MERGED] [IMPROVEMENT] getting rid of the warnings during rust builds

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1497 **Author:** [@ArchitBhonsle](https://github.com/ArchitBhonsle) **Created:** 3/13/2023 **Status:** ✅ Merged **Merged:** 3/15/2023 **Merged by:** [@PunitLodha](https://github.com/PunitLodha) **Base:** `master` ← **Head:** `remove-rust-build-warnings` --- ### 📝 Commits (1) - [`3c1967c`](https://github.com/CCExtractor/ccextractor/commit/3c1967cadb05b80f5e3bd3de5bc8175f0abd4d67) getting rid of the warnings during rust builds ### 📊 Changes **1 file changed** (+6 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/rust/build.rs` (+6 -4) </details> ### 📄 Description **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [ ] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [x] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- #1469 brought this up where we would get some warnings when compiling the rust module without the `hardsubx_ocr` feature. As stated later in the issue these `mut`s are actually necessary when the feature is turned on. This fix is a minor change which removes the warnings in both the cases. This might allow us to maybe use `RUSTFLAGS="--deny warnings"` in our workflows to fail on warnings. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia commented

2026-01-29 17:20:57 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1497
Author: @ArchitBhonsle
Created: 3/13/2023
Status: ✅ Merged
Merged: 3/15/2023
Merged by: @PunitLodha

Base: master ← Head: remove-rust-build-warnings

📝 Commits (1)

3c1967c getting rid of the warnings during rust builds

📊 Changes

1 file changed (+6 additions, -4 deletions)

View changed files

📝 src/rust/build.rs (+6 -4)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.
I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

#1469 brought this up where we would get some warnings when compiling the rust module without the hardsubx_ocr feature. As stated later in the issue these muts are actually necessary when the feature is turned on. This fix is a minor change which removes the warnings in both the cases. This might allow us to maybe use RUSTFLAGS="--deny warnings" in our workflows to fail on warnings.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 17:20:57 +00:00

[PR #1497] [MERGED] [IMPROVEMENT] getting rid of the warnings during rust builds #2225

📋 Pull Request Information

📝 Commits (1)

📊 Changes

📄 Description