[PR #1522] [MERGED] [FIX] encoding of solid block in latin-1 and unicode #2246

Closed
opened 2026-01-29 17:21:07 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1522
Author: @elbertronnie
Created: 3/29/2023
Status: Merged
Merged: 3/30/2023
Merged by: @cfsmp3

Base: masterHead: fix-encoding-solid-block


📝 Commits (3)

  • fbdd6e7 Fix encoding of solid block in latin1 and unicode
  • 23253c4 mention in CHANGES.TXT
  • df8b138 Add missing break

📊 Changes

2 files changed (+7 additions, -0 deletions)

View changed files

📝 docs/CHANGES.TXT (+1 -0)
📝 src/lib_ccx/ccx_common_char_encoding.c (+6 -0)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

The solid block character in Line-21 encoding (0x7f) is correctly encoded when converted to UTF-8 as E2 96 A0 (which is U+25A0). But this character is missing in the conversion to latin-1 and unicode.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1522 **Author:** [@elbertronnie](https://github.com/elbertronnie) **Created:** 3/29/2023 **Status:** ✅ Merged **Merged:** 3/30/2023 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `fix-encoding-solid-block` --- ### 📝 Commits (3) - [`fbdd6e7`](https://github.com/CCExtractor/ccextractor/commit/fbdd6e77ffd6673222e1e850b56b19405893a853) Fix encoding of solid block in latin1 and unicode - [`23253c4`](https://github.com/CCExtractor/ccextractor/commit/23253c45dd1af61a90ba659ce3935dddfbb78512) mention in CHANGES.TXT - [`df8b138`](https://github.com/CCExtractor/ccextractor/commit/df8b13896edd0f9ef224a0ee10bc31b7fc5bab8a) Add missing break ### 📊 Changes **2 files changed** (+7 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `docs/CHANGES.TXT` (+1 -0) 📝 `src/lib_ccx/ccx_common_char_encoding.c` (+6 -0) </details> ### 📄 Description <!-- Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. --> **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [x] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [x] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- The solid block character in Line-21 encoding (`0x7f`) is correctly encoded when converted to UTF-8 as `E2 96 A0` (which is `U+25A0`). But this character is missing in the conversion to latin-1 and unicode. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:21:07 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2246