starred/ccextractor
1
0
Fork 0
mirror of https://github.com/CCExtractor/ccextractor.git synced 2026-04-20 13:03:58 +00:00
Code Issues 1.5k Packages Projects Releases 21 Wiki Activity

[PR #1547] [CLOSED] [FEAT] Add argument parsing in ccextractor rust #2266

New Issue
Open
opened 2026-01-29 17:21:14 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 17:21:14 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1547
Author: @prateekmedia
Created: 7/28/2023
Status: ❌ Closed

Base: master ← Head: rusty-ccextractor

📝 Commits (10+)

📊 Changes

26 files changed (+6178 additions, -1131 deletions)

View changed files

📝 .github/workflows/build_mac.yml (+21 -16)
➕ .github/workflows/test_rust.yml (+36 -0)
📝 .gitignore (+4 -1)
📝 docs/FFMPEG.md (+1 -1)
📝 docs/OCR.md (+2 -2)
📝 mac/Makefile.am (+2 -1)
📝 src/ccextractor.c (+4 -0)
📝 src/lib_ccx/ccx_decoders_708_output.c (+4 -11)
📝 src/lib_ccx/lib_ccx.h (+3 -0)
📝 src/lib_ccx/params.c (+9 -3)
📝 src/rust/Cargo.lock (+306 -113)
📝 src/rust/Cargo.toml (+14 -3)
📝 src/rust/build.rs (+14 -0)
➕ src/rust/src/activity.rs (+15 -0)
➕ src/rust/src/args.rs (+1009 -0)
➕ src/rust/src/ccx_encoders_helpers.rs (+65 -0)
➕ src/rust/src/common.rs (+1311 -0)
📝 src/rust/src/lib.rs (+83 -1)
➕ src/rust/src/parser.rs (+2264 -0)
📝 src/rust/src/utils.rs (+29 -0)

...and 6 more files

📄 Description

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Rewrote argument parsing with all the structs and enums too into rust.

Help arguments demo:
image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1547 **Author:** [@prateekmedia](https://github.com/prateekmedia) **Created:** 7/28/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `rusty-ccextractor` --- ### 📝 Commits (10+) - [`71c83b6`](https://github.com/CCExtractor/ccextractor/commit/71c83b6dfdd48bc7d7c0157f2ab3790cdd935926) feat: unpack gpac - [`b8b5994`](https://github.com/CCExtractor/ccextractor/commit/b8b599447aeb12731fe052dae046b7ce4f95d2cb) fix: linux ci - [`1c9d7b5`](https://github.com/CCExtractor/ccextractor/commit/1c9d7b507c8fd518a3bce5fae7227623166c9bf8) fix: mac build - [`e3fecf9`](https://github.com/CCExtractor/ccextractor/commit/e3fecf9370fe11184692044a579f1e3fa78cc862) fix: remove unused [no ci] - [`3b1e5d0`](https://github.com/CCExtractor/ccextractor/commit/3b1e5d0f3a16cb1fa97fa0bd842ac3cbd5574f3c) fix: ignore config.h [no ci] - [`9ed4fe0`](https://github.com/CCExtractor/ccextractor/commit/9ed4fe0174d32deafba0a5a843e9ce9b2d6a0e40) temp commit, will drop this soon - [`82c30ce`](https://github.com/CCExtractor/ccextractor/commit/82c30cedc6f15eb015d67da463300944558c1ae8) fix: install gpac - [`c99950a`](https://github.com/CCExtractor/ccextractor/commit/c99950a5c46b299e2109966c49c05fd435159241) fix: gpac - [`0794d92`](https://github.com/CCExtractor/ccextractor/commit/0794d926f52d63ed0f23df72a7a3b08ea35c3a2c) fix: formatting - [`4d18e2e`](https://github.com/CCExtractor/ccextractor/commit/4d18e2e043cbbd6b35ab89ee4f25990b4652391c) fix: preproccessor directive ### 📊 Changes **26 files changed** (+6178 additions, -1131 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build_mac.yml` (+21 -16) ➕ `.github/workflows/test_rust.yml` (+36 -0) 📝 `.gitignore` (+4 -1) 📝 `docs/FFMPEG.md` (+1 -1) 📝 `docs/OCR.md` (+2 -2) 📝 `mac/Makefile.am` (+2 -1) 📝 `src/ccextractor.c` (+4 -0) 📝 `src/lib_ccx/ccx_decoders_708_output.c` (+4 -11) 📝 `src/lib_ccx/lib_ccx.h` (+3 -0) 📝 `src/lib_ccx/params.c` (+9 -3) 📝 `src/rust/Cargo.lock` (+306 -113) 📝 `src/rust/Cargo.toml` (+14 -3) 📝 `src/rust/build.rs` (+14 -0) ➕ `src/rust/src/activity.rs` (+15 -0) ➕ `src/rust/src/args.rs` (+1009 -0) ➕ `src/rust/src/ccx_encoders_helpers.rs` (+65 -0) ➕ `src/rust/src/common.rs` (+1311 -0) 📝 `src/rust/src/lib.rs` (+83 -1) ➕ `src/rust/src/parser.rs` (+2264 -0) 📝 `src/rust/src/utils.rs` (+29 -0) _...and 6 more files_ </details> ### 📄 Description <!-- Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. --> **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [ ] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [x] I am an active contributor to CCExtractor. --- Rewrote argument parsing with all the structs and enums too into rust. Help arguments demo: ![image](https://github.com/CCExtractor/ccextractor/assets/41370460/1d7cc7f4-7446-492a-a152-a337823abf9e) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:21:14 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
CEA-708
difficulty: easy
difficulty: hard
difficulty: medium
DTMB
DVB
enhancement
enhancement
Flutter GUI
GCI19
good-first-task
GSoC 2021
GSOC-2023
GSOC-2023
GSOC-2023
GSoC-related
Hacktoberfest
HardsubX
help wanted
invalid
JokerTV
Mac / OSX
more-info-needed
needs-commercial-sponsor
needs-commercial-sponsor
needs-commercial-sponsor
needs-confirmation-of-being-broken
OCR
pull-request
Mirrored from GitHub Pull Request
 Python
regression
Rust
teletext
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2266
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?