[PR #1599] [CLOSED] [WIP] [FIX] Initialize data structures for the rust CEA-708 decoder and correct Dtvcc

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1599 **Author:** [@IshanGrover2004](https://github.com/IshanGrover2004) **Created:** 2/20/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `1499-initialize-dtvcc-ds` --- ### 📄 Description  **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [x] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [x] I am an active contributor to CCExtractor. --- Closes #1499 Work to be done in this PR: - [x] Change Dtvcc::new() to create Dtvcc using ccx_decoder_dtvcc_settings as done [here]( https://github.com/CCExtractor/ccextractor/blob/master/src/lib_ccx/ccx_dtvcc.c#L76-L124) - [x] Create a new extern C fn `ccxr_dtvcc_init()` in [lib.rs](https://github.com/CCExtractor/ccextractor/blob/master/src/rust/src/lib.rs) and use this at all places where `dtvcc_init()` is being called. (Probably add a new struct field to lib_cc_decode like `dtvcc_rust` and store Dtvcc there instead of using the dtvcc field) - [ ] Similar for `dtvcc_free()` - [ ] Change [ccxr_process_cc_data](https://github.com/CCExtractor/ccextractor/blob/master/src/rust/src/lib.rs#L53-L75) to use Dtvcc from `dec_ctx` instead of creating a new one Additionally to fix mp4 code flow:- - [ ] Call the corresponding rust function [here](https://github.com/CCExtractor/ccextractor/blob/master/src/lib_ccx/mp4.c#L398) and pass Dtvcc as done in the above steps --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia commented

2026-01-29 17:21:27 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1599
Author: @IshanGrover2004
Created: 2/20/2024
Status: ❌ Closed

Base: master ← Head: 1499-initialize-dtvcc-ds

📄 Description

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.
I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

Closes #1499

Work to be done in this PR:

Change Dtvcc::new() to create Dtvcc using ccx_decoder_dtvcc_settings as done here
Create a new extern C fn ccxr_dtvcc_init() in lib.rs and use this at all places where dtvcc_init() is being called. (Probably add a new struct field to lib_cc_decode like dtvcc_rust and store Dtvcc there instead of using the dtvcc field)
Similar for dtvcc_free()
Change ccxr_process_cc_data to use Dtvcc from dec_ctx instead of creating a new one

Additionally to fix mp4 code flow:-

Call the corresponding rust function here and pass Dtvcc as done in the above steps

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 17:21:27 +00:00

claunia closed this issue

[PR #1599] [CLOSED] [WIP] [FIX] Initialize data structures for the rust CEA-708 decoder and correct Dtvcc #2311

📋 Pull Request Information

📄 Description