[PR #1609] [MERGED] [FIX] Unexpected behavior of get_write_interval

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1609 **Author:** [@IshanGrover2004](https://github.com/IshanGrover2004) **Created:** 5/11/2024 **Status:** ✅ Merged **Merged:** 5/24/2024 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `fix-get-write-interval-fn` --- ### 📝 Commits (2) - [`2d13ede`](https://github.com/CCExtractor/ccextractor/commit/2d13ede178bc7e0f1a6ff397ca4cf54e3d334539) fix: Unexpected behavior of get_write_interval - [`920b44e`](https://github.com/CCExtractor/ccextractor/commit/920b44e1b9a15240e782e375d6bc91bb2569e281) docs: Add changes to `CHANGES.TXT` ### 📊 Changes **2 files changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `docs/CHANGES.TXT` (+1 -0) 📝 `src/rust/src/decoder/tv_screen.rs` (+2 -1) </details> ### 📄 Description **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [x] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [x] I am an active contributor to CCExtractor. --- Closes #1606 ### Issue addresed This pull request addresses issue #1606 where the [get_write_interval](https://github.com/CCExtractor/ccextractor/blob/3f504412f54dc88cdcfbdbf56e4657d51a6d9b49/src/rust/src/decoder/tv_screen.rs#L106) function incorrectly returns (0,209) for a packet does not contain captions, implying that caption packets are available from index 0 to 209 which needs to be corrected. ### Correction Made The correction ensures that the correct interval (0,0) is returned, indicating that there are no captions available to write. ### Implementation Details By initialising `last` variable which stores last caption available by 0 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia commented

2026-01-29 17:21:29 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1609
Author: @IshanGrover2004
Created: 5/11/2024
Status: ✅ Merged
Merged: 5/24/2024
Merged by: @cfsmp3

Base: master ← Head: fix-get-write-interval-fn

📝 Commits (2)

2d13ede fix: Unexpected behavior of get_write_interval
920b44e docs: Add changes to CHANGES.TXT

📊 Changes

2 files changed (+3 additions, -1 deletions)

View changed files

📝 docs/CHANGES.TXT (+1 -0)
📝 src/rust/src/decoder/tv_screen.rs (+2 -1)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.
I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

Closes #1606

Issue addresed

This pull request addresses issue #1606 where the get_write_interval function incorrectly returns (0,209) for a packet does not contain captions, implying that caption packets are available from index 0 to 209 which needs to be corrected.

Correction Made

The correction ensures that the correct interval (0,0) is returned, indicating that there are no captions available to write.

Implementation Details

By initialising last variable which stores last caption available by 0

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 17:21:29 +00:00

[PR #1609] [MERGED] [FIX] Unexpected behavior of get_write_interval #2320