[PR #1612] [MERGED] [FIX (Windows)] CI build #2327

Open
opened 2026-01-29 17:21:31 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1612
Author: @prateekmedia
Created: 5/28/2024
Status: Merged
Merged: 5/28/2024
Merged by: @PunitLodha

Base: masterHead: windows-ci-fixes


📝 Commits (1)

📊 Changes

5 files changed (+213 additions, -536 deletions)

View changed files

📝 .github/workflows/build_windows.yml (+47 -26)
windows/.gitignore (+2 -0)
📝 windows/ccextractor.vcxproj (+25 -22)
📝 windows/ccextractor.vcxproj.filters (+129 -488)
windows/vcpkg.json (+10 -0)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Windows CI was broken due to not pinning of dependencies


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1612 **Author:** [@prateekmedia](https://github.com/prateekmedia) **Created:** 5/28/2024 **Status:** ✅ Merged **Merged:** 5/28/2024 **Merged by:** [@PunitLodha](https://github.com/PunitLodha) **Base:** `master` ← **Head:** `windows-ci-fixes` --- ### 📝 Commits (1) - [`96cb829`](https://github.com/CCExtractor/ccextractor/commit/96cb82991e7e8d7e66e7eb225bbd11c839a31e60) fix(windows): ci build ### 📊 Changes **5 files changed** (+213 additions, -536 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build_windows.yml` (+47 -26) ➕ `windows/.gitignore` (+2 -0) 📝 `windows/ccextractor.vcxproj` (+25 -22) 📝 `windows/ccextractor.vcxproj.filters` (+129 -488) ➕ `windows/vcpkg.json` (+10 -0) </details> ### 📄 Description <!-- Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. --> **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [ ] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [x] I am an active contributor to CCExtractor. --- Windows CI was broken due to not pinning of dependencies --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:21:31 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2327