[PR #1624] [MERGED] [FEAT] Add constants module in lib_ccxr #2335

Closed
opened 2026-01-29 17:21:34 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1624
Author: @IshanGrover2004
Created: 7/12/2024
Status: Merged
Merged: 7/16/2024
Merged by: @PunitLodha

Base: masterHead: migration-common-constants-module


📝 Commits (5)

  • 3d31f73 feat: Add common module
  • 3b1a371 feat: Add constants module within common module
  • ce123fc feat: Add all constants, enums in rust equivaleent to ccx_common_constansts C file
  • f753193 docs: Mention in Changelogs
  • aa9cca9 docs: Add more conversion data

📊 Changes

4 files changed (+622 additions, -0 deletions)

View changed files

📝 docs/CHANGES.TXT (+1 -0)
src/rust/lib_ccxr/src/common/constants.rs (+617 -0)
src/rust/lib_ccxr/src/common/mod.rs (+3 -0)
📝 src/rust/lib_ccxr/src/lib.rs (+1 -0)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Closes #1555

This PR adds some common enums & constants which will be used througjout the codebase. This PR code is equivalent to ccx_common_constants C file.

NOTE: Most of these enums are completely unrelated to each other and the only reason they are kept together for now is because they were kept together in C codebase. In the future when appropriate modules will be built, each of them will have to tranfered to their respective meaningful modules.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1624 **Author:** [@IshanGrover2004](https://github.com/IshanGrover2004) **Created:** 7/12/2024 **Status:** ✅ Merged **Merged:** 7/16/2024 **Merged by:** [@PunitLodha](https://github.com/PunitLodha) **Base:** `master` ← **Head:** `migration-common-constants-module` --- ### 📝 Commits (5) - [`3d31f73`](https://github.com/CCExtractor/ccextractor/commit/3d31f73e2e4d4038d548c8938e4e0873406841fa) feat: Add common module - [`3b1a371`](https://github.com/CCExtractor/ccextractor/commit/3b1a37106086a241324b217c299bfcff79a0a968) feat: Add constants module within common module - [`ce123fc`](https://github.com/CCExtractor/ccextractor/commit/ce123fcc1331a0f88449ee8e27520af9f06ed4c9) feat: Add all constants, enums in rust equivaleent to `ccx_common_constansts` C file - [`f753193`](https://github.com/CCExtractor/ccextractor/commit/f753193cd174bf12ae8a0cc39f72c8b4857810eb) docs: Mention in Changelogs - [`aa9cca9`](https://github.com/CCExtractor/ccextractor/commit/aa9cca979f6cdc98ca96f399af61b11342c2c122) docs: Add more conversion data ### 📊 Changes **4 files changed** (+622 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `docs/CHANGES.TXT` (+1 -0) ➕ `src/rust/lib_ccxr/src/common/constants.rs` (+617 -0) ➕ `src/rust/lib_ccxr/src/common/mod.rs` (+3 -0) 📝 `src/rust/lib_ccxr/src/lib.rs` (+1 -0) </details> ### 📄 Description <!-- Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. --> **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [x] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [x] I am an active contributor to CCExtractor. --- Closes #1555 This PR adds some common enums & constants which will be used througjout the codebase. This PR code is equivalent to `ccx_common_constants` C file. NOTE: Most of these enums are completely unrelated to each other and the only reason they are kept together for now is because they were kept together in C codebase. In the future when appropriate modules will be built, each of them will have to tranfered to their respective meaningful modules. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:21:34 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2335