mirror of
https://github.com/CCExtractor/ccextractor.git
synced 2026-02-03 21:23:48 +00:00
[PR #1624] [MERGED] [FEAT] Add constants module in lib_ccxr
#2335
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/CCExtractor/ccextractor/pull/1624
Author: @IshanGrover2004
Created: 7/12/2024
Status: ✅ Merged
Merged: 7/16/2024
Merged by: @PunitLodha
Base:
master← Head:migration-common-constants-module📝 Commits (5)
3d31f73feat: Add common module3b1a371feat: Add constants module within common modulece123fcfeat: Add all constants, enums in rust equivaleent toccx_common_constanstsC filef753193docs: Mention in Changelogsaa9cca9docs: Add more conversion data📊 Changes
4 files changed (+622 additions, -0 deletions)
View changed files
📝
docs/CHANGES.TXT(+1 -0)➕
src/rust/lib_ccxr/src/common/constants.rs(+617 -0)➕
src/rust/lib_ccxr/src/common/mod.rs(+3 -0)📝
src/rust/lib_ccxr/src/lib.rs(+1 -0)📄 Description
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Closes #1555
This PR adds some common enums & constants which will be used througjout the codebase. This PR code is equivalent to
ccx_common_constantsC file.NOTE: Most of these enums are completely unrelated to each other and the only reason they are kept together for now is because they were kept together in C codebase. In the future when appropriate modules will be built, each of them will have to tranfered to their respective meaningful modules.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.