starred/ccextractor
1
0
Fork 0
mirror of https://github.com/CCExtractor/ccextractor.git synced 2026-04-19 04:22:49 +00:00
Code Issues 1.5k Packages Projects Releases 21 Wiki Activity

[PR #1640] [MERGED] [FEAT] Add timing module in lib_ccxr #2350

New Issue
Open
opened 2026-01-29 17:21:41 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 17:21:41 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1640
Author: @IshanGrover2004
Created: 8/31/2024
Status: ✅ Merged
Merged: 9/14/2024
Merged by: @PunitLodha

Base: master ← Head: migration-timing-module

📝 Commits (10+)

  • e13e529 feat: Add new module for timings functionality
  • 1d0b925 feat: Add timing functionality in timing.rs module
  • a23405f feat: List all module & function conversion
  • 93c7f5f chore: Clippy fixes
  • d8d2b10 feat: Equivalent ccx_common_timing.h functions in rust module
  • 6772aaf feat: Add static constants & include struct in build.rs
  • 758f212 feat: Add extern C functions
  • 62422b2 feat: Include & use rust extern functions in C
  • 8948581 fix: Windows build
  • 414048b fix: Windows build

📊 Changes

12 files changed (+1150 additions, -12 deletions)

View changed files

📝 src/lib_ccx/ccx_common_timing.c (+47 -0)
📝 src/rust/build.rs (+1 -0)
📝 src/rust/lib_ccxr/src/common/options.rs (+1 -1)
➕ src/rust/lib_ccxr/src/time/c_functions.rs (+61 -0)
📝 src/rust/lib_ccxr/src/time/mod.rs (+23 -1)
➕ src/rust/lib_ccxr/src/time/timing.rs (+559 -0)
📝 src/rust/lib_ccxr/src/time/units.rs (+13 -1)
📝 src/rust/src/decoder/mod.rs (+1 -1)
📝 src/rust/src/decoder/service_decoder.rs (+1 -1)
📝 src/rust/src/lib.rs (+14 -2)
📝 src/rust/src/libccxr_exports/mod.rs (+1 -1)
📝 src/rust/src/libccxr_exports/time.rs (+428 -4)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Closes #1558

This PR adds types and functions to store and calculate timing related information during the decoding process. The functions are integrated into C.
After this PR merge, ccx_common_timing.c & ccx_common_timing.h file is completed ported to rust

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1640 **Author:** [@IshanGrover2004](https://github.com/IshanGrover2004) **Created:** 8/31/2024 **Status:** ✅ Merged **Merged:** 9/14/2024 **Merged by:** [@PunitLodha](https://github.com/PunitLodha) **Base:** `master` ← **Head:** `migration-timing-module` --- ### 📝 Commits (10+) - [`e13e529`](https://github.com/CCExtractor/ccextractor/commit/e13e529f5ba7d6088f3e771b3fabff4e1406feda) feat: Add new module for timings functionality - [`1d0b925`](https://github.com/CCExtractor/ccextractor/commit/1d0b92587caa7d48c033e847146e87c032702a4c) feat: Add timing functionality in `timing.rs` module - [`a23405f`](https://github.com/CCExtractor/ccextractor/commit/a23405f54db85cfced14443443f7bc45a196760b) feat: List all module & function conversion - [`93c7f5f`](https://github.com/CCExtractor/ccextractor/commit/93c7f5fc194aaef2b541592e06aebd1494d71318) chore: Clippy fixes - [`d8d2b10`](https://github.com/CCExtractor/ccextractor/commit/d8d2b1027e888c131051cfe637821a351f59868b) feat: Equivalent `ccx_common_timing.h` functions in rust module - [`6772aaf`](https://github.com/CCExtractor/ccextractor/commit/6772aafda52fb674bb017718c8487930d154f2d7) feat: Add static constants & include struct in `build.rs` - [`758f212`](https://github.com/CCExtractor/ccextractor/commit/758f212e33050e15d1009023bf6c91c4ed9b91c1) feat: Add extern C functions - [`62422b2`](https://github.com/CCExtractor/ccextractor/commit/62422b23615621a2201e3c246baabaa67fe114e5) feat: Include & use rust extern functions in C - [`8948581`](https://github.com/CCExtractor/ccextractor/commit/89485814ed834bdcc90dfb1a770cf3cc00c64217) fix: Windows build - [`414048b`](https://github.com/CCExtractor/ccextractor/commit/414048b4ec8e7bd49cb5b15c4ff40098c9ebca12) fix: Windows build ### 📊 Changes **12 files changed** (+1150 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/ccx_common_timing.c` (+47 -0) 📝 `src/rust/build.rs` (+1 -0) 📝 `src/rust/lib_ccxr/src/common/options.rs` (+1 -1) ➕ `src/rust/lib_ccxr/src/time/c_functions.rs` (+61 -0) 📝 `src/rust/lib_ccxr/src/time/mod.rs` (+23 -1) ➕ `src/rust/lib_ccxr/src/time/timing.rs` (+559 -0) 📝 `src/rust/lib_ccxr/src/time/units.rs` (+13 -1) 📝 `src/rust/src/decoder/mod.rs` (+1 -1) 📝 `src/rust/src/decoder/service_decoder.rs` (+1 -1) 📝 `src/rust/src/lib.rs` (+14 -2) 📝 `src/rust/src/libccxr_exports/mod.rs` (+1 -1) 📝 `src/rust/src/libccxr_exports/time.rs` (+428 -4) </details> ### 📄 Description **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [x] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [x] I am an active contributor to CCExtractor. --- Closes #1558 This PR adds types and functions to store and calculate timing related information during the decoding process. The functions are integrated into C. After this PR merge, `ccx_common_timing.c` & `ccx_common_timing.h` file is completed ported to rust --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:21:41 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
CEA-708
difficulty: easy
difficulty: hard
difficulty: medium
DTMB
DVB
enhancement
enhancement
Flutter GUI
GCI19
good-first-task
GSoC 2021
GSOC-2023
GSOC-2023
GSOC-2023
GSoC-related
Hacktoberfest
HardsubX
help wanted
invalid
JokerTV
Mac / OSX
more-info-needed
needs-commercial-sponsor
needs-commercial-sponsor
needs-commercial-sponsor
needs-confirmation-of-being-broken
OCR
pull-request
Mirrored from GitHub Pull Request
 Python
regression
Rust
teletext
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2350
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?