[PR #1638] [MERGED] [FIX] Issues in Tests #2351

Closed
opened 2026-01-29 17:21:41 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1638
Author: @prateekmedia
Created: 8/28/2024
Status: Merged
Merged: 9/2/2024
Merged by: @PunitLodha

Base: masterHead: ci-fixes


📝 Commits (4)

  • f2bbcdb fix: add ucla checks for millis_separator
  • 7e01acd fix: reassign back profane and capitalization lists to c
  • 66b5016 fix: C formatting
  • fa9a404 fix(rust): clippy warnings

📊 Changes

10 files changed (+68 additions, -27 deletions)

View changed files

📝 src/lib_ccx/ccx_encoders_helpers.c (+0 -7)
📝 src/lib_ccx/ccx_encoders_helpers.h (+7 -3)
📝 src/lib_ccx/ccx_encoders_spupng.c (+1 -1)
src/lib_ccx/ccx_encoders_spupng.h (+4 -0)
📝 src/rust/build.rs (+1 -4)
📝 src/rust/lib_ccxr/src/common/options.rs (+20 -0)
📝 src/rust/src/common.rs (+13 -3)
📝 src/rust/src/lib.rs (+15 -5)
📝 src/rust/src/parser.rs (+6 -4)
📝 src/rust/wrapper.h (+1 -0)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

As SamplePlatform ran tests, some issues were encountered. This PR fixes those.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1638 **Author:** [@prateekmedia](https://github.com/prateekmedia) **Created:** 8/28/2024 **Status:** ✅ Merged **Merged:** 9/2/2024 **Merged by:** [@PunitLodha](https://github.com/PunitLodha) **Base:** `master` ← **Head:** `ci-fixes` --- ### 📝 Commits (4) - [`f2bbcdb`](https://github.com/CCExtractor/ccextractor/commit/f2bbcdb72a0fae628bfab5aa321facbbf4ea3c3d) fix: add ucla checks for millis_separator - [`7e01acd`](https://github.com/CCExtractor/ccextractor/commit/7e01acd3a5c762a348c399b623627f12f19a48b3) fix: reassign back profane and capitalization lists to c - [`66b5016`](https://github.com/CCExtractor/ccextractor/commit/66b501645600e0d12ead067a6fc637a94b499724) fix: C formatting - [`fa9a404`](https://github.com/CCExtractor/ccextractor/commit/fa9a404393e7a65a6418610d54fa9ec51057eb4d) fix(rust): clippy warnings ### 📊 Changes **10 files changed** (+68 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/ccx_encoders_helpers.c` (+0 -7) 📝 `src/lib_ccx/ccx_encoders_helpers.h` (+7 -3) 📝 `src/lib_ccx/ccx_encoders_spupng.c` (+1 -1) ➕ `src/lib_ccx/ccx_encoders_spupng.h` (+4 -0) 📝 `src/rust/build.rs` (+1 -4) 📝 `src/rust/lib_ccxr/src/common/options.rs` (+20 -0) 📝 `src/rust/src/common.rs` (+13 -3) 📝 `src/rust/src/lib.rs` (+15 -5) 📝 `src/rust/src/parser.rs` (+6 -4) 📝 `src/rust/wrapper.h` (+1 -0) </details> ### 📄 Description <!-- Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. --> **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [ ] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [x] I am an active contributor to CCExtractor. --- As SamplePlatform ran tests, some issues were encountered. This PR fixes those. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:21:41 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2351