[PR #1650] [CLOSED] Update build.rs #2357

Open
opened 2026-01-29 17:21:43 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1650
Author: @qxrein
Created: 12/26/2024
Status: Closed

Base: masterHead: patch-1


📝 Commits (2)

📊 Changes

1 file changed (+23 additions, -22 deletions)

View changed files

📝 src/rust/build.rs (+23 -22)

📄 Description

Moved RUSTIFIED_ENUMS before main()
Added proper error handling with Result
Converted unwrap() and expect() to ?
Maintained all existing comments and line structure

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

{pull request content here}


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1650 **Author:** [@qxrein](https://github.com/qxrein) **Created:** 12/26/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (2) - [`37cb83a`](https://github.com/CCExtractor/ccextractor/commit/37cb83afc777a10a3d53bfe5bfd8c5f7e5be9b16) Update build.rs - [`5a93b25`](https://github.com/CCExtractor/ccextractor/commit/5a93b25919298106bf4aa0e092f0855d2c97c7d2) Update build.rs ### 📊 Changes **1 file changed** (+23 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `src/rust/build.rs` (+23 -22) </details> ### 📄 Description Moved RUSTIFIED_ENUMS before main() Added proper error handling with Result Converted unwrap() and expect() to ? Maintained all existing comments and line structure <!-- Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. --> **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [ ] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [ ] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [x] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- {pull request content here} --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:21:43 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2357