[PR #1649] [MERGED] [FEAT] Add bitstream module in lib_ccxr #2358

Closed
opened 2026-01-29 17:21:43 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1649
Author: @mrswastik-robot
Created: 12/25/2024
Status: Merged
Merged: 7/7/2025
Merged by: @prateekmedia

Base: masterHead: migration-bitstream-module


📝 Commits (10+)

📊 Changes

9 files changed (+1386 additions, -6 deletions)

View changed files

📝 src/lib_ccx/cc_bitstream.c (+64 -1)
📝 src/lib_ccx/cc_bitstream.h (+0 -1)
📝 src/rust/build.rs (+1 -0)
src/rust/lib_ccxr/src/common/bitstream.rs (+460 -0)
📝 src/rust/lib_ccxr/src/common/mod.rs (+2 -0)
📝 src/rust/lib_ccxr/src/util/bits.rs (+4 -4)
src/rust/src/libccxr_exports/bitstream.rs (+852 -0)
📝 src/rust/src/libccxr_exports/mod.rs (+2 -0)
📝 src/rust/wrapper.h (+1 -0)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

This PR migrates the bitstream functionality from C to Rust while maintaining backward compatibility by creating a new Rust implementation in lib_ccxr/src/common/bitstream.rs and connecting it to the existing C code through FFI bindings.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1649 **Author:** [@mrswastik-robot](https://github.com/mrswastik-robot) **Created:** 12/25/2024 **Status:** ✅ Merged **Merged:** 7/7/2025 **Merged by:** [@prateekmedia](https://github.com/prateekmedia) **Base:** `master` ← **Head:** `migration-bitstream-module` --- ### 📝 Commits (10+) - [`83fb2d7`](https://github.com/CCExtractor/ccextractor/commit/83fb2d7a8f177c60415049509f64ba86ab7d1e04) feat: Add bitstream module - [`c3a91a6`](https://github.com/CCExtractor/ccextractor/commit/c3a91a6d387bfc16075a85b4a56dfe41c47435a2) run code formatters - [`c873193`](https://github.com/CCExtractor/ccextractor/commit/c87319305d9897effb30e7d9961aea546e1ff6ab) Run cargo clippy --fix - [`37e126a`](https://github.com/CCExtractor/ccextractor/commit/37e126a868f25ed156ecaaa0db7b422fd28495a2) Run cargo fmt --all - [`666a1bf`](https://github.com/CCExtractor/ccextractor/commit/666a1bf07b0fc7e0aeab90574f24d4af060235d9) refactor: remove rust pointer from C struct - [`d70fcd3`](https://github.com/CCExtractor/ccextractor/commit/d70fcd34c5c7ce1d8176f52c0a3c2f5e56302e44) feat: Add bitstream module - [`e9a9155`](https://github.com/CCExtractor/ccextractor/commit/e9a91550505a1d71132af959e1090059d92db3d1) run code formatters - [`bdb0c5f`](https://github.com/CCExtractor/ccextractor/commit/bdb0c5f1ab22a320bb9cf3036478946e084fe700) Run cargo clippy --fix - [`d869d7c`](https://github.com/CCExtractor/ccextractor/commit/d869d7c8621f97deb75a4775ce6af3f2867e6f9f) Run cargo fmt --all - [`04a0eed`](https://github.com/CCExtractor/ccextractor/commit/04a0eed470fac49f8b1a72ad4c2385ff39ba3a2b) refactor: remove rust pointer from C struct ### 📊 Changes **9 files changed** (+1386 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/cc_bitstream.c` (+64 -1) 📝 `src/lib_ccx/cc_bitstream.h` (+0 -1) 📝 `src/rust/build.rs` (+1 -0) ➕ `src/rust/lib_ccxr/src/common/bitstream.rs` (+460 -0) 📝 `src/rust/lib_ccxr/src/common/mod.rs` (+2 -0) 📝 `src/rust/lib_ccxr/src/util/bits.rs` (+4 -4) ➕ `src/rust/src/libccxr_exports/bitstream.rs` (+852 -0) 📝 `src/rust/src/libccxr_exports/mod.rs` (+2 -0) 📝 `src/rust/wrapper.h` (+1 -0) </details> ### 📄 Description <!-- Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. --> **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [ ] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [x] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- This PR migrates the bitstream functionality from C to Rust while maintaining backward compatibility by creating a new Rust implementation in `lib_ccxr/src/common/bitstream.rs` and connecting it to the existing C code through FFI bindings. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:21:43 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2358