[PR #1666] [MERGED] [FIX] Fix c formatting issues and fix some rust warnings #2369

Open
opened 2026-01-29 17:21:47 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1666
Author: @canihavesomecoffee
Created: 2/22/2025
Status: Merged
Merged: 2/22/2025
Merged by: @canihavesomecoffee

Base: masterHead: fix/formatting


📝 Commits (3)

  • cea450e fix: reformat C code according to latest clang-format guidelines
  • f07680d fix: fix 2 rust clippy warnings/errors
  • f4c404c fix: fix clippy warning/error in lib_ccxr

📊 Changes

9 files changed (+29 additions, -29 deletions)

View changed files

📝 src/lib_ccx/asf_functions.c (+1 -1)
📝 src/lib_ccx/ccx_decoders_common.c (+1 -1)
📝 src/lib_ccx/ccx_encoders_spupng.c (+1 -1)
📝 src/lib_ccx/dvb_subtitle_decoder.c (+8 -8)
📝 src/lib_ccx/general_loop.c (+1 -1)
📝 src/lib_ccx/hardsubx_decoder.c (+1 -1)
📝 src/rust/lib_ccxr/src/util/bits.rs (+4 -4)
📝 src/rust/src/decoder/encoding.rs (+11 -11)
📝 src/rust/src/decoder/mod.rs (+1 -1)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog. (Not applicable)

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Fixes the C formatting issues and fixes all but one clippy warnings that are being triggered on the CI pipelines


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1666 **Author:** [@canihavesomecoffee](https://github.com/canihavesomecoffee) **Created:** 2/22/2025 **Status:** ✅ Merged **Merged:** 2/22/2025 **Merged by:** [@canihavesomecoffee](https://github.com/canihavesomecoffee) **Base:** `master` ← **Head:** `fix/formatting` --- ### 📝 Commits (3) - [`cea450e`](https://github.com/CCExtractor/ccextractor/commit/cea450e0427e17b22333970608f109c9e045c40c) fix: reformat C code according to latest clang-format guidelines - [`f07680d`](https://github.com/CCExtractor/ccextractor/commit/f07680dc1a7192d3776a42485e456708526235c1) fix: fix 2 rust clippy warnings/errors - [`f4c404c`](https://github.com/CCExtractor/ccextractor/commit/f4c404c7ba5ecaaa2642fdc0fee06b219b3ff062) fix: fix clippy warning/error in lib_ccxr ### 📊 Changes **9 files changed** (+29 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/asf_functions.c` (+1 -1) 📝 `src/lib_ccx/ccx_decoders_common.c` (+1 -1) 📝 `src/lib_ccx/ccx_encoders_spupng.c` (+1 -1) 📝 `src/lib_ccx/dvb_subtitle_decoder.c` (+8 -8) 📝 `src/lib_ccx/general_loop.c` (+1 -1) 📝 `src/lib_ccx/hardsubx_decoder.c` (+1 -1) 📝 `src/rust/lib_ccxr/src/util/bits.rs` (+4 -4) 📝 `src/rust/src/decoder/encoding.rs` (+11 -11) 📝 `src/rust/src/decoder/mod.rs` (+1 -1) </details> ### 📄 Description <!-- Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. --> **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [x] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** (Not applicable) **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [x] I am an active contributor to CCExtractor. --- Fixes the C formatting issues and fixes all but one clippy warnings that are being triggered on the CI pipelines --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:21:47 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2369